Introduce chrome.shell.createWindow stub API for app_shell

Introduce chrome.shell.createWindow stub API for app_shell

The chrome.app.window.create API has too many Chrome dependencies to be practically extracted from src/chrome. Rather than create an incomplete chrome.app.window API stub just for app_shell, introduce chrome.shell.createWindow which can be used in place of chrome.app.window with a small stub.

* Introduce chrome.shell.createWindow for app_shell.
* Introduce an app_shell_resources target to hold the resource for the chrome.shell custom bindings JS.
* Extend ExtensionsRendererClient to allow an extensions embedder to supply additional custom APIs.
* Modify the Calculator example to use a small chrome.shell polyfill for window creation.

BUG=349042
TEST=browser_tests *Extension*, app_shell --app=<path/to/calculator/app> loads calculator
TBR=isherman@chromium.org for mechanical update of existing ExtensionFunction enum in histograms.xml

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267159

[James Cook, 2014-04-25 22:35:53]

rockot, PTAL

[Ken Rockot(use gerrit already), 2014-04-26 00:17:39]

Nice. I have no comments. LGTM!

https://codereview.chromium.org/254473011/diff/20001/apps/shell/app_shell.gyp
File apps/shell/app_shell.gyp (right):

https://codereview.chromium.org/254473011/diff/20001/apps/shell/app_shell.gyp...
apps/shell/app_shell.gyp:11: 'target_name': 'app_shell_resources',
Woot

[James Cook, 2014-04-28 17:44:51]

miket, PTAL at *extensions*. Ken and I thought it was cleaner to have a separate
chrome.shell API call than to introduce an incomplete stub of chrome.app.window.

sky, PTAL at:
chrome/renderer/chrome_content_renderer_client.* and
chrome/test/base/chrome_render_view_test.*

ExtensionsRendererClient needs to be set up before Dispatcher is created.  I
think eliminating the extra reference to |extension_dispatcher_| in
ChromeRenderViewTest also makes ownership a little clearer.

[sky, 2014-04-28 20:24:51]

LGTM

[James Cook, 2014-04-28 20:36:04]

yoz, can you take a look at this instead of Mike?  He's travelling.

Ken and I thought it was cleaner to have a separate chrome.shell API call than
to introduce an incomplete stub of chrome.app.window.

[James Cook, 2014-04-28 21:04:19]

https://codereview.chromium.org/254473011/diff/80001/apps/shell/common/api/sh...
File apps/shell/common/api/shell.idl (right):

https://codereview.chromium.org/254473011/diff/80001/apps/shell/common/api/sh...
apps/shell/common/api/shell.idl:5: // Use the <code>chrome.shell</code> API to
watch for launch events and create
I'm also planning to add an onLaunched event to this API that can be used
instead of chrome.app.runtime.onLaunched.

[Yoyo Zhou, 2014-04-29 22:10:00]

I was traveling too. =(
LGTM with nits

https://chromiumcodereview.appspot.com/254473011/diff/80001/apps/shell/browse...
File apps/shell/browser/api/shell/shell_api.h (right):

https://chromiumcodereview.appspot.com/254473011/diff/80001/apps/shell/browse...
apps/shell/browser/api/shell/shell_api.h:23:
DECLARE_EXTENSION_FUNCTION("shell.createWindow", UNKNOWN);
Are we ok with not having histograms for this function?

https://chromiumcodereview.appspot.com/254473011/diff/80001/apps/shell/common...
File apps/shell/common/api/shell.idl (right):

https://chromiumcodereview.appspot.com/254473011/diff/80001/apps/shell/common...
apps/shell/common/api/shell.idl:6: // windows. The createWindow API is a subset
of
<code>createWindow</code>

https://chromiumcodereview.appspot.com/254473011/diff/80001/apps/shell/common...
apps/shell/common/api/shell.idl:16: // app_shell but are provided for
compatibility with apps running in Chrome.
nit: change this . to a semicolon.

[James Cook, 2014-04-29 22:53:52]

https://codereview.chromium.org/254473011/diff/80001/apps/shell/browser/api/s...
File apps/shell/browser/api/shell/shell_api.h (right):

https://codereview.chromium.org/254473011/diff/80001/apps/shell/browser/api/s...
apps/shell/browser/api/shell/shell_api.h:23:
DECLARE_EXTENSION_FUNCTION("shell.createWindow", UNKNOWN);
On 2014/04/29 22:10:00, Yoyo Zhou wrote:
> Are we ok with not having histograms for this function?

Added one.

https://codereview.chromium.org/254473011/diff/80001/apps/shell/common/api/sh...
File apps/shell/common/api/shell.idl (right):

https://codereview.chromium.org/254473011/diff/80001/apps/shell/common/api/sh...
apps/shell/common/api/shell.idl:6: // windows. The createWindow API is a subset
of
On 2014/04/29 22:10:00, Yoyo Zhou wrote:
> <code>createWindow</code>

Done.

https://codereview.chromium.org/254473011/diff/80001/apps/shell/common/api/sh...
apps/shell/common/api/shell.idl:16: // app_shell but are provided for
compatibility with apps running in Chrome.
On 2014/04/29 22:10:00, Yoyo Zhou wrote:
> nit: change this . to a semicolon.

Done.

[James Cook, 2014-04-29 23:16:55]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-04-29 23:18:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/254473011/120001

[commit-bot: I haz the power, 2014-04-30 00:23:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-30 00:23:34]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium

[Yoyo Zhou, 2014-04-30 00:25:55]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-04-30 00:28:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/254473011/120001

[commit-bot: I haz the power, 2014-04-30 01:04:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-30 01:04:28]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium

[James Cook, 2014-04-30 02:27:48]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-04-30 02:30:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/254473011/140001

[commit-bot: I haz the power, 2014-04-30 10:34:57]

Change committed as 267159