content/common/media/media_player_messages_android.h - Issue 254473010: Refactor MSE implementation on Android to simplify the logic and improve the performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/media/media_player_messages_android.h

Issue 254473010: Refactor MSE implementation on Android to simplify the logic and improve the performance (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressing comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/android/browser_demuxer_android.cc ('k') | content/renderer/media/android/media_source_delegate.h » ('j') | content/renderer/media/android/media_source_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/media/media_player_messages_android.h

diff --git a/content/common/media/media_player_messages_android.h b/content/common/media/media_player_messages_android.h

index 40dd56e2c6e9a17ac531769b923757472886c7b0..12fdcf19cfc8973c7adce866dcc460e9837b89c7 100644

--- a/content/common/media/media_player_messages_android.h

+++ b/content/common/media/media_player_messages_android.h

@@ -42,6 +42,7 @@ IPC_STRUCT_TRAITS_END()

IPC_STRUCT_TRAITS_BEGIN(media::DemuxerData)

IPC_STRUCT_TRAITS_MEMBER(type)

IPC_STRUCT_TRAITS_MEMBER(access_units)

+ IPC_STRUCT_TRAITS_MEMBER(demuxer_configs)

IPC_STRUCT_TRAITS_END()

IPC_STRUCT_TRAITS_BEGIN(media::AccessUnit)

@@ -175,10 +176,6 @@ IPC_MESSAGE_CONTROL2(MediaPlayerMsg_ReadFromDemuxer,

int /* demuxer_client_id */,

media::DemuxerStream::Type /* type */)

-// The player needs new config data

-IPC_MESSAGE_CONTROL1(MediaPlayerMsg_MediaConfigRequest,

- int /* demuxer_client_id */)

// Clank has connected to the remote device.

IPC_MESSAGE_ROUTED2(MediaPlayerMsg_ConnectedToRemoteDevice,

int /* player_id */,