Refactor MSE implementation on Android to simplify the logic and improve the performance

media/base/android/audio_decoder_job.h

Index: media/base/android/audio_decoder_job.h
diff --git a/media/base/android/audio_decoder_job.h b/media/base/android/audio_decoder_job.h
index 4a37038c430cd5055a34c94bd89ec4953413d06f..6df7f1f3690a352d880b97deb7b95fc884ac95e8 100644
--- a/media/base/android/audio_decoder_job.h
+++ b/media/base/android/audio_decoder_job.h
@@ -6,6 +6,7 @@
 #define MEDIA_BASE_ANDROID_AUDIO_DECODER_JOB_H_
 
 #include <jni.h>
+#include <vector>
 
 #include "media/base/android/media_decoder_job.h"
 
@@ -17,33 +18,23 @@ class AudioTimestampHelper;
 // Class for managing audio decoding jobs.
 class AudioDecoderJob : public MediaDecoderJob {
  public:
-  virtual ~AudioDecoderJob();
-
   // Creates a new AudioDecoderJob instance for decoding audio.
-  // |audio_codec| - The audio format the object needs to decode.
-  // |sample_rate| - The sample rate of the decoded output.
-  // |channel_count| - The number of channels in the decoded output.
-  // |extra_data|, |extra_data_size| - Extra data buffer needed for initializing
-  // the decoder.
-  // |media_crypto| - Handle to a Java object that handles the encryption for
-  // the audio data.
   // |request_data_cb| - Callback used to request more data for the decoder.
-  static AudioDecoderJob* Create(
-      const AudioCodec audio_codec, int sample_rate, int channel_count,
-      const uint8* extra_data, size_t extra_data_size, jobject media_crypto,
-      const base::Closure& request_data_cb);
+  // |on_demuxer_config_changed_cb| - Callback used to inform the caller that
+  // demuxer config has changed.
+  AudioDecoderJob(const base::Closure& request_data_cb,

[xhwang, 2014/05/30 21:58:07]

Add include for base::Closure.

[qinmin, 2014/05/30 23:43:33]

Done.

+                  const base::Closure& on_demuxer_config_changed_cb);
+  ~AudioDecoderJob();

[xhwang, 2014/05/30 21:58:07]

virtual

[qinmin, 2014/05/30 23:43:33]

Done.

+

[xhwang, 2014/05/30 21:58:07]

// MediaDecoderJob implementation.

[qinmin, 2014/05/30 23:43:33]

Done.

+  virtual bool HasStream() const OVERRIDE;
 
+  // Set the volume of the audio output.

[xhwang, 2014/05/30 21:58:07]

nit: Set_s_

[qinmin, 2014/05/30 23:43:33]

this is not a simple setter, it calls another function.

On 2014/05/30 21:58:07, xhwang wrote:

[xhwang, 2014/06/02 23:07:11]

Sorry for not being clear. I was simply suggesting s/Set/Sets in the comment.

[qinmin, 2014/06/03 00:41:03]

Done.

   void SetVolume(double volume);
 
   // Sets the base timestamp for |audio_timestamp_helper_|.
   void SetBaseTimestamp(base::TimeDelta base_timestamp);
 
  private:
-  AudioDecoderJob(scoped_ptr<AudioTimestampHelper> audio_timestamp_helper,
-                  scoped_ptr<AudioCodecBridge> audio_decoder_bridge,
-                  int bytes_per_frame,
-                  const base::Closure& request_data_cb);
-
   // MediaDecoderJob implementation.
   virtual void ReleaseOutputBuffer(
       int output_buffer_index,
@@ -51,16 +42,30 @@ class AudioDecoderJob : public MediaDecoderJob {
       bool render_output,
       base::TimeDelta current_presentation_timestamp,
       const ReleaseOutputCompletionCallback& callback) OVERRIDE;
-
   virtual bool ComputeTimeToRender() const OVERRIDE;
-
-  // number of bytes per audio frame;
+  virtual bool IsDemuxerConfigChanged(
+      const DemuxerConfigs& configs) const OVERRIDE;
+  virtual void UpdateDemuxerConfigs(const DemuxerConfigs& configs) OVERRIDE;
+  virtual bool CreateMediaCodecBridgeInternal() OVERRIDE;
+
+  // Helper method to set the audio output volume.
+  void SetVolumeInternal();
+
+  // Audio configs from the demuxer.
+  AudioCodec audio_codec_;
+  int num_channels_;
+  int sampling_rate_;
+  std::vector<uint8> audio_extra_data_;
+  double volume_;
   int bytes_per_frame_;
 
-  scoped_ptr<AudioCodecBridge> audio_codec_bridge_;
+  // Base timestamp for the |audio_timestamp_helper_|.
+  base::TimeDelta base_timestamp_;
 
   // Object to calculate the current audio timestamp for A/V sync.
   scoped_ptr<AudioTimestampHelper> audio_timestamp_helper_;
+
+  DISALLOW_COPY_AND_ASSIGN(AudioDecoderJob);
 };
 
 }  // namespace media