sync: Introduce classes for per-type counters

sync/internal_api/public/sessions/commit_counters.h

Index: sync/internal_api/public/sessions/commit_counters.h
diff --git a/sync/internal_api/public/sessions/commit_counters.h b/sync/internal_api/public/sessions/commit_counters.h
new file mode 100644
index 0000000000000000000000000000000000000000..38ff5e4757d3d43601c3431e655683fecd72df4c
--- /dev/null
+++ b/sync/internal_api/public/sessions/commit_counters.h
@@ -0,0 +1,31 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SYNC_INTERNAL_API_PUBLIC_SESSIONS_COMMIT_COUNTERS_H_
+#define SYNC_INTERNAL_API_PUBLIC_SESSIONS_COMMIT_COUNTERS_H_
+
+#include "base/memory/scoped_ptr.h"
+#include "base/values.h"
+#include "sync/base/sync_export.h"
+
+namespace syncer {
+
+// A class to maintain counts related to sync commit requests and responses.
+class SYNC_EXPORT_PRIVATE CommitCounters {
+ public:
+  CommitCounters();
+  ~CommitCounters();
+
+  scoped_ptr<base::DictionaryValue> ToValue() const;
+  std::string ToString() const;
+
+  int num_commits_attempted;

[tim (not reviewing), 2014/04/28 21:26:21]

Make this a struct if you want public data members. ToValue and ToString are
commonly found on structs.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Structs_vs._Cl...

[rlarocque, 2014/04/28 21:59:59]

Done.

+  int num_commits_success;
+  int num_commits_conflict;
+  int num_commits_error;
+};
+
+}  // namespace syncer
+
+#endif  // SYNC_INTERNAL_API_PUBLIC_SESSIONS_COMMIT_COUNTERS_H_