Add media::StreamParser::StreamParameter struct.

Add media::StreamParser::InitParameter struct.

The new struct is used to pass parameters to StreamParser::InitCB. This
change makes it easier to add new parameters.

BUG=338529
Committed: http://src.chromium.org/viewvc/chrome?revision=266077&view=revision

[acolwell GONE FROM CHROMIUM, 2014-04-24 21:00:55]

lgtm % nits

https://codereview.chromium.org/254473006/diff/1/media/base/stream_parser.h
File media/base/stream_parser.h (right):

https://codereview.chromium.org/254473006/diff/1/media/base/stream_parser.h#n...
media/base/stream_parser.h:50: struct StreamParameters {
nit: s/Stream// or s/Stream/Init/ so we don't have double the "Stream" at most
use sites. :)?

https://codereview.chromium.org/254473006/diff/1/media/base/stream_parser.h#n...
media/base/stream_parser.h:51: StreamParameters();
nit: I think we should at least force duration to be passed here.

https://codereview.chromium.org/254473006/diff/1/media/base/stream_parser.h#n...
media/base/stream_parser.h:109: StreamParser();
Why is this needed? Should we be using a differend DISALLOW_ below instead?

https://codereview.chromium.org/254473006/diff/1/media/formats/mpeg/mpeg_audi...
File media/formats/mpeg/mpeg_audio_stream_parser_base.cc (right):

https://codereview.chromium.org/254473006/diff/1/media/formats/mpeg/mpeg_audi...
media/formats/mpeg/mpeg_audio_stream_parser_base.cc:227: success,
StreamParser::StreamParameters());
This changes the behavior. auto_update_timestamp_offset needs to be set to true
here.

[Sergey Ulanov, 2014-04-24 22:13:42]

https://codereview.chromium.org/254473006/diff/1/media/base/stream_parser.h
File media/base/stream_parser.h (right):

https://codereview.chromium.org/254473006/diff/1/media/base/stream_parser.h#n...
media/base/stream_parser.h:50: struct StreamParameters {
On 2014/04/24 21:00:55, acolwell wrote:
> nit: s/Stream// or s/Stream/Init/ so we don't have double the "Stream" at most
> use sites. :)?

Done.

https://codereview.chromium.org/254473006/diff/1/media/base/stream_parser.h#n...
media/base/stream_parser.h:51: StreamParameters();
On 2014/04/24 21:00:55, acolwell wrote:
> nit: I think we should at least force duration to be passed here.

Done.

https://codereview.chromium.org/254473006/diff/1/media/base/stream_parser.h#n...
media/base/stream_parser.h:109: StreamParser();
On 2014/04/24 21:00:55, acolwell wrote:
> Why is this needed? Should we be using a differend DISALLOW_ below instead?

I just moved them here from line 49. Style guide says types should defined
before constructor.

https://codereview.chromium.org/254473006/diff/1/media/formats/mpeg/mpeg_audi...
File media/formats/mpeg/mpeg_audio_stream_parser_base.cc (right):

https://codereview.chromium.org/254473006/diff/1/media/formats/mpeg/mpeg_audi...
media/formats/mpeg/mpeg_audio_stream_parser_base.cc:227: success,
StreamParser::StreamParameters());
On 2014/04/24 21:00:55, acolwell wrote:
> This changes the behavior. auto_update_timestamp_offset needs to be set to
true
> here.

Thanks for catching this!

[Sergey Ulanov, 2014-04-24 22:13:54]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2014-04-24 22:14:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/254473006/20001

[commit-bot: I haz the power, 2014-04-24 23:21:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 23:21:05]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[Sergey Ulanov, 2014-04-25 01:07:11]

landed as 266077