Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: base/prefs/pref_service.h

Issue 254473002: Add support for int64 and uint64 in values.h's API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix test compile Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/prefs/pref_registry_simple.cc ('k') | base/prefs/pref_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/prefs/pref_service.h
diff --git a/base/prefs/pref_service.h b/base/prefs/pref_service.h
index 186433c1b62907c16eb3360ca8d567ca2b1a07a6..e2c57d283b22d6c8a6cf1f5e2dba44ba4dbc85fa 100644
--- a/base/prefs/pref_service.h
+++ b/base/prefs/pref_service.h
@@ -173,6 +173,8 @@ class BASE_PREFS_EXPORT PrefService : public base::NonThreadSafe {
int GetInteger(const char* path) const;
double GetDouble(const char* path) const;
std::string GetString(const char* path) const;
+ int64 GetInt64(const char* path) const;
+ uint64 GetUint64(const char* path) const;
base::FilePath GetFilePath(const char* path) const;
// Returns the branch if it exists, or the registered default value otherwise.
@@ -195,17 +197,9 @@ class BASE_PREFS_EXPORT PrefService : public base::NonThreadSafe {
void SetInteger(const char* path, int value);
void SetDouble(const char* path, double value);
void SetString(const char* path, const std::string& value);
- void SetFilePath(const char* path, const base::FilePath& value);
-
- // Int64 helper methods that actually store the given value as a string.
- // Note that if obtaining the named value via GetDictionary or GetList, the
- // Value type will be TYPE_STRING.
void SetInt64(const char* path, int64 value);
- int64 GetInt64(const char* path) const;
-
- // As above, but for unsigned values.
void SetUint64(const char* path, uint64 value);
- uint64 GetUint64(const char* path) const;
+ void SetFilePath(const char* path, const base::FilePath& value);
// Returns the value of the given preference, from the user pref store. If
// the preference is not set in the user pref store, returns NULL.
« no previous file with comments | « base/prefs/pref_registry_simple.cc ('k') | base/prefs/pref_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698