Add support for int64 and uint64 in values.h's API.

base/prefs/pref_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/prefs/pref_service.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/default_pref_store.h"
 #include "base/prefs/pref_notifier_impl.h"
 #include "base/prefs/pref_registry.h"
 #include "base/prefs/pref_value_store.h"
 #include "base/stl_util.h"
-#include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/value_conversions.h"
 #include "build/build_config.h"
 
 namespace {
 
 class ReadErrorHandler : public PersistentPrefStore::ReadErrorDelegate {
  public:
   ReadErrorHandler(base::Callback<void(PersistentPrefStore::PrefReadError)> cb)
       : callback_(cb) {}
@@ skipping 109 matching lines @@
   const base::Value* value = GetPreferenceValue(path);
   if (!value) {
     NOTREACHED() << "Trying to read an unregistered pref: " << path;
     return result;
   }
   bool rv = value->GetAsString(&result);
   DCHECK(rv);
   return result;
 }
 
+int64 PrefService::GetInt64(const char* path) const {
+  DCHECK(CalledOnValidThread());
+
+  int64 result = 0;
+
+  const base::Value* value = GetPreferenceValue(path);
+  if (!value) {
+    NOTREACHED() << "Trying to read an unregistered pref: " << path;
+    return result;
+  }
+  bool rv = value->GetAsInt64(&result);
+  DCHECK(rv);
+  return result;
+}
+
+uint64 PrefService::GetUint64(const char* path) const {
+  DCHECK(CalledOnValidThread());
+
+  uint64 result = 0;
+
+  const base::Value* value = GetPreferenceValue(path);
+  if (!value) {
+    NOTREACHED() << "Trying to read an unregistered pref: " << path;
+    return result;
+  }
+  bool rv = value->GetAsUint64(&result);
+  DCHECK(rv);
+  return result;
+}
+
 base::FilePath PrefService::GetFilePath(const char* path) const {
   DCHECK(CalledOnValidThread());
 
   base::FilePath result;
 
   const base::Value* value = GetPreferenceValue(path);
   if (!value) {
     NOTREACHED() << "Trying to read an unregistered pref: " << path;
     return base::FilePath(result);
   }
@@ skipping 187 matching lines @@
 }
 
 void PrefService::SetDouble(const char* path, double value) {
   SetUserPrefValue(path, new base::FundamentalValue(value));
 }
 
 void PrefService::SetString(const char* path, const std::string& value) {
   SetUserPrefValue(path, new base::StringValue(value));
 }
 
+void PrefService::SetInt64(const char* path, int64 value) {
+  SetUserPrefValue(path, new base::StringValue(value));
+}
+
+void PrefService::SetUint64(const char* path, uint64 value) {
+  SetUserPrefValue(path, new base::StringValue(value));
+}
+
 void PrefService::SetFilePath(const char* path, const base::FilePath& value) {
   SetUserPrefValue(path, base::CreateFilePathValue(value));
 }
 
-void PrefService::SetInt64(const char* path, int64 value) {
-  SetUserPrefValue(path, new base::StringValue(base::Int64ToString(value)));
-}
-
-int64 PrefService::GetInt64(const char* path) const {
-  DCHECK(CalledOnValidThread());
-
-  const base::Value* value = GetPreferenceValue(path);
-  if (!value) {
-    NOTREACHED() << "Trying to read an unregistered pref: " << path;
-    return 0;
-  }
-  std::string result("0");
-  bool rv = value->GetAsString(&result);
-  DCHECK(rv);
-
-  int64 val;
-  base::StringToInt64(result, &val);
-  return val;
-}
-
-void PrefService::SetUint64(const char* path, uint64 value) {
-  SetUserPrefValue(path, new base::StringValue(base::Uint64ToString(value)));
-}
-
-uint64 PrefService::GetUint64(const char* path) const {
-  DCHECK(CalledOnValidThread());
-
-  const base::Value* value = GetPreferenceValue(path);
-  if (!value) {
-    NOTREACHED() << "Trying to read an unregistered pref: " << path;
-    return 0;
-  }
-  std::string result("0");
-  bool rv = value->GetAsString(&result);
-  DCHECK(rv);
-
-  uint64 val;
-  base::StringToUint64(result, &val);
-  return val;
-}
-
 base::Value* PrefService::GetMutableUserPref(const char* path,
                                              base::Value::Type type) {
   CHECK(type == base::Value::TYPE_DICTIONARY || type == base::Value::TYPE_LIST);
   DCHECK(CalledOnValidThread());
 
   const Preference* pref = FindPreference(path);
   if (!pref) {
     NOTREACHED() << "Trying to get an unregistered pref: " << path;
     return NULL;
   }
@@ skipping 134 matching lines @@
       DCHECK(found_value->IsType(default_type));
       return found_value;
     } else {
       // Every registered preference has at least a default value.
       NOTREACHED() << "no valid value found for registered pref " << path;
     }
   }
 
   return NULL;
 }