Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: src/compiler/code-assembler.cc

Issue 2544713003: [stubs] Remove representation parameter from Store() operations that trigger full write barrier. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/code-assembler.h ('k') | src/ic/keyed-store-generic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-assembler.h" 5 #include "src/compiler/code-assembler.h"
6 6
7 #include <ostream> 7 #include <ostream>
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/compiler/graph.h" 10 #include "src/compiler/graph.h"
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 return HeapConstant(Handle<HeapObject>::cast(root)); 300 return HeapConstant(Handle<HeapObject>::cast(root));
301 } 301 }
302 } 302 }
303 303
304 Node* roots_array_start = 304 Node* roots_array_start =
305 ExternalConstant(ExternalReference::roots_array_start(isolate())); 305 ExternalConstant(ExternalReference::roots_array_start(isolate()));
306 return Load(MachineType::AnyTagged(), roots_array_start, 306 return Load(MachineType::AnyTagged(), roots_array_start,
307 IntPtrConstant(root_index * kPointerSize)); 307 IntPtrConstant(root_index * kPointerSize));
308 } 308 }
309 309
310 Node* CodeAssembler::Store(MachineRepresentation rep, Node* base, Node* value) { 310 Node* CodeAssembler::Store(Node* base, Node* value) {
311 return raw_assembler()->Store(rep, base, value, kFullWriteBarrier); 311 return raw_assembler()->Store(MachineRepresentation::kTagged, base, value,
312 kFullWriteBarrier);
312 } 313 }
313 314
314 Node* CodeAssembler::Store(MachineRepresentation rep, Node* base, Node* offset, 315 Node* CodeAssembler::Store(Node* base, Node* offset, Node* value) {
315 Node* value) { 316 return raw_assembler()->Store(MachineRepresentation::kTagged, base, offset,
316 return raw_assembler()->Store(rep, base, offset, value, kFullWriteBarrier); 317 value, kFullWriteBarrier);
317 } 318 }
318 319
319 Node* CodeAssembler::StoreNoWriteBarrier(MachineRepresentation rep, Node* base, 320 Node* CodeAssembler::StoreNoWriteBarrier(MachineRepresentation rep, Node* base,
320 Node* value) { 321 Node* value) {
321 return raw_assembler()->Store(rep, base, value, kNoWriteBarrier); 322 return raw_assembler()->Store(rep, base, value, kNoWriteBarrier);
322 } 323 }
323 324
324 Node* CodeAssembler::StoreNoWriteBarrier(MachineRepresentation rep, Node* base, 325 Node* CodeAssembler::StoreNoWriteBarrier(MachineRepresentation rep, Node* base,
325 Node* offset, Node* value) { 326 Node* offset, Node* value) {
326 return raw_assembler()->Store(rep, base, offset, value, kNoWriteBarrier); 327 return raw_assembler()->Store(rep, base, offset, value, kNoWriteBarrier);
(...skipping 878 matching lines...) Expand 10 before | Expand all | Expand 10 after
1205 } 1206 }
1206 } 1207 }
1207 } 1208 }
1208 1209
1209 bound_ = true; 1210 bound_ = true;
1210 } 1211 }
1211 1212
1212 } // namespace compiler 1213 } // namespace compiler
1213 } // namespace internal 1214 } // namespace internal
1214 } // namespace v8 1215 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/code-assembler.h ('k') | src/ic/keyed-store-generic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698