Issue 25447004: Linux: fix calls to "which" in maintainer scripts to be non-fatal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25447004: Linux: fix calls to "which" in maintainer scripts to be non-fatal (Closed)

Created:
7 years, 2 months ago by Paweł Hajdan Jr.

Modified:
7 years, 2 months ago

Reviewers:
Michael Moss

CC:
chromium-reviews, grt+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Linux: fix calls to "which" in maintainer scripts to be non-fatal "which" doesn't provide useful error messages on errors. When failure to find a program is fatal, we explicitly print an error message explaining the problem. Some failure to find a program are actually intended to be non-fatal, e.g. update-menus. BUG=303624 R=mmoss@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226825

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	chrome/installer/linux/common/postinst.include	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	M	chrome/installer/linux/common/prerm.include	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

7 years, 2 months ago (2013-10-03 20:10:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r226825 (presubmit successful).

Expand Messages | Collapse Messages