Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 25447003: Make svndiff.py work on Windows and with svn 1.7. (Closed)

Created:
7 years, 2 months ago by bungeman-skia
Modified:
7 years, 2 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Make svndiff.py work on Windows and with svn 1.7. R=epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=11642

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M tools/svn.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/svndiff.py View 1 4 chunks +18 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bungeman-skia
Yes, I know that svn is going away and all that, but I had these ...
7 years, 2 months ago (2013-10-02 21:54:10 UTC) #1
bungeman-skia
With patch set 2, this now fixes the problems I was having on Windows as ...
7 years, 2 months ago (2013-10-04 15:50:26 UTC) #2
epoger
LGTM Thanks for the improvements!
7 years, 2 months ago (2013-10-07 18:36:24 UTC) #3
bungeman-skia
7 years, 2 months ago (2013-10-07 19:57:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r11642 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698