[MD settings] i18n source stream filtering

content/browser/webui/web_ui_data_source_impl.cc

Index: content/browser/webui/web_ui_data_source_impl.cc
diff --git a/content/browser/webui/web_ui_data_source_impl.cc b/content/browser/webui/web_ui_data_source_impl.cc
index 2d6d24a916d5f43ec1a34d25881678357dd0c934..deac3e0efbdbfc356c49b167479f71ab2dabe40a 100644
--- a/content/browser/webui/web_ui_data_source_impl.cc
+++ b/content/browser/webui/web_ui_data_source_impl.cc
@@ -212,6 +212,10 @@ void WebUIDataSourceImpl::DisableI18nAndUseGzipForAllPaths() {
   use_gzip_for_all_paths_ = true;
 }
 
+const ui::TemplateReplacements* WebUIDataSourceImpl::GetReplacements() const {
+  return &replacements_;
+}
+
 std::string WebUIDataSourceImpl::GetSource() const {
   return source_name_;
 }
@@ -270,18 +274,6 @@ void WebUIDataSourceImpl::StartDataRequest(
   DCHECK_NE(resource_id, -1);
   scoped_refptr<base::RefCountedMemory> response(
       GetContentClient()->GetDataResourceBytes(resource_id));
-
-  // TODO(dschuyler): improve filtering of which resource to run template
-  // expansion upon. TODO(dbeam): make a streaming filter that works on gzipped
-  // content.
-  if (response.get() && GetMimeType(path) == "text/html" &&

[Dan Beam, 2016/12/01 23:32:23]

so how are we only running replacements on text/html without this block?

[dschuyler, 2016/12/02 20:14:00]

Done.

-      !source()->IsGzipped(path)) {
-    std::string replaced = ui::ReplaceTemplateExpressions(
-        base::StringPiece(response->front_as<char>(), response->size()),
-        replacements_);
-    response = base::RefCountedString::TakeString(&replaced);
-  }
-
   callback.Run(response.get());
 }