[MD settings] i18n source stream filtering

content/browser/webui/i18n_source_stream.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_WEBUI_I18N_SOURCE_STREAM_H_
+#define CONTENT_BROWSER_WEBUI_I18N_SOURCE_STREAM_H_
+
+#include <memory>
+#include <string>
+
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "net/base/io_buffer.h"
+#include "net/filter/filter_source_stream.h"
+#include "ui/base/template_expressions.h"
+
+namespace content {
+
+class NET_EXPORT_PRIVATE I18nSourceStream : public net::FilterSourceStream {
+ public:
+  ~I18nSourceStream() override;
+
+  // Factory function to create an I18nSourceStream.
+  static std::unique_ptr<I18nSourceStream> Create(
+      std::unique_ptr<SourceStream> previous,
+      SourceStream::SourceType type);

[Dan Beam, 2016/12/01 05:57:22]

why can't this just take a TemplateReplacements as a ctor arg and we ditch
SetReplacements?

static std::unique_ptr<I18nSourceStream> Create(
    std::unique_ptr<SourceStream> previous,
    SourceStream::SourceType type,
    const ui::TemplateReplacements* replacements);

[dschuyler, 2016/12/01 23:07:26]

Done.

+
+  // Specify the dictionary of i18n replacements.
+  void SetReplacements(const ui::TemplateReplacements* replacements);

[Dan Beam, 2016/12/01 05:57:22]

also, this should be set_replacements() if it stays (it's just a vanilla setter,
not doing anything hard, nor is it virtual)

you could potentially even do it inline in the header...

[dschuyler, 2016/12/01 23:07:26]

Let's go with removing it.

+
+ private:
+  // Accumulated from upstream.
+  std::string input_;
+
+  // To send downstream.
+  std::string output_;
+
+  // A map of i18n replacement keys and translations.
+  const ui::TemplateReplacements* replacements_;  // weak
+
+  I18nSourceStream(std::unique_ptr<SourceStream> previous,
+                   SourceStream::SourceType type);
+
+  // SourceStream implementation.
+  std::string GetTypeAsString() const override;
+  int FilterData(net::IOBuffer* output_buffer,
+                 int output_buffer_size,
+                 net::IOBuffer* input_buffer,
+                 int input_buffer_size,
+                 int* consumed_bytes,
+                 bool upstream_end_reached) override;
+
+  DISALLOW_COPY_AND_ASSIGN(I18nSourceStream);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_WEBUI_I18N_SOURCE_STREAM_H_