Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2544653002:
Adding back Mouse Focus on |sendContextMenuEventForGesture| (Closed)
DescriptionAdding back Mouse Focus on |sendContextMenuEventForGesture|
The CL crrev.com/2480353006 introduced a bug by not changing focus on gesture
generated context menus. This CL adds back the logic changing focus logic.
BUG=668034
Committed: https://crrev.com/8a905053d9c4b7eb7b238356d52e6d0e24bc40b6
Cr-Commit-Position: refs/heads/master@{#435663}
Patch Set 1 #
Messages
Total messages: 17 (11 generated)
The CQ bit was checked by amaralp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Adding back Mouse Focus on |sendContextMenEventForGesture| BUG=668034 ========== to ========== Adding back Mouse Focus on |sendContextMenEventForGesture| The CL crrev.com/2480353006 introduced a bug by not changing focus on gesture generated context menus. This CL adds back the logic changing focus logic. BUG=668034 ==========
amaralp@chromium.org changed reviewers: + bokan@chromium.org, mustaq@chromium.org
PTAL
lgtm
Description was changed from ========== Adding back Mouse Focus on |sendContextMenEventForGesture| The CL crrev.com/2480353006 introduced a bug by not changing focus on gesture generated context menus. This CL adds back the logic changing focus logic. BUG=668034 ========== to ========== Adding back Mouse Focus on |sendContextMenuEventForGesture| The CL crrev.com/2480353006 introduced a bug by not changing focus on gesture generated context menus. This CL adds back the logic changing focus logic. BUG=668034 ==========
Please wrap the commit message at 80 cols. lgtm
Description was changed from ========== Adding back Mouse Focus on |sendContextMenuEventForGesture| The CL crrev.com/2480353006 introduced a bug by not changing focus on gesture generated context menus. This CL adds back the logic changing focus logic. BUG=668034 ========== to ========== Adding back Mouse Focus on |sendContextMenuEventForGesture| The CL crrev.com/2480353006 introduced a bug by not changing focus on gesture generated context menus. This CL adds back the logic changing focus logic. BUG=668034 ==========
The CQ bit was checked by amaralp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480618377140560, "parent_rev":
"5550897ffa9038d0d3e754742934d9761fde68d3", "commit_rev":
"9ab00750adeed55451be6390b2bc12fa3d00da5c"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Adding back Mouse Focus on |sendContextMenuEventForGesture| The CL crrev.com/2480353006 introduced a bug by not changing focus on gesture generated context menus. This CL adds back the logic changing focus logic. BUG=668034 ========== to ========== Adding back Mouse Focus on |sendContextMenuEventForGesture| The CL crrev.com/2480353006 introduced a bug by not changing focus on gesture generated context menus. This CL adds back the logic changing focus logic. BUG=668034 Committed: https://crrev.com/8a905053d9c4b7eb7b238356d52e6d0e24bc40b6 Cr-Commit-Position: refs/heads/master@{#435663} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8a905053d9c4b7eb7b238356d52e6d0e24bc40b6 Cr-Commit-Position: refs/heads/master@{#435663} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
