Issue 254463006: This CL contains all of the changes for splitting off all of the native

Issue 254463006: This CL contains all of the changes for splitting off all of the native (Closed)

Created:
6 years, 8 months ago by Leaf

Modified:
6 years, 8 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

This CL contains all of the changes for splitting off all of the native calls from dart:html into dart:blink. As currently configured, the dart:blink library will be empty and unused. The only changes in the idl generated dart and C++ code in the default configuration should be cosmetic. The global variable "dart_use_blink" in systemnative.py currently controls whether or not the real blink library is generated. Enabling this requires as yet unchecked in changes to blink. These changes are expected to land as part of the chrome 35 roll. Support for building with/without blink DOM changes for checked receivers Dartium native call generation refactor BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=35430

Patch Set 1 #

Total comments: 4

Patch Set 2 : Additional cleanup, eliminate now unused generality #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+445 lines, -140 lines)			Patch
M	tools/dom/scripts/dartdomgenerator.py	View	1	2 chunks	+11 lines, -6 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View		2 chunks	+47 lines, -7 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	tools/dom/scripts/idlrenderer.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1	8 chunks	+20 lines, -19 lines	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	1	18 chunks	+241 lines, -68 lines	0 comments	Download
M	tools/dom/scripts/templateloader_test.py	View		1 chunk	+1 line, -1 line	0 comments	Download
A	tools/dom/src/blink_native_DOMImplementation.dart	View		1 chunk	+58 lines, -0 lines	0 comments	Download
A +	tools/dom/src/html_native_DOMImplementation.dart	View		6 chunks	+28 lines, -25 lines	0 comments	Download
A +	tools/dom/templates/html/dartium/blink_dartium.darttemplate	View		1 chunk	+10 lines, -8 lines	0 comments	Download
M	tools/dom/templates/html/dartium/chrome_dartium.darttemplate	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/dartium/indexed_db_dartium.darttemplate	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/dartium/svg_dartium.darttemplate	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/dartium/web_audio_dartium.darttemplate	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/dartium/web_gl_dartium.darttemplate	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/dartium/web_sql_dartium.darttemplate	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm, but please re-run go.sh https://codereview.chromium.org/254463006/diff/1/tools/dom/scripts/systemnative.py File tools/dom/scripts/systemnative.py (right): https://codereview.chromium.org/254463006/diff/1/tools/dom/scripts/systemnative.py#newcode174 tools/dom/scripts/systemnative.py:174: _single_blink = True Can ...

6 years, 8 months ago (2014-04-24 23:16:53 UTC) #2

Leaf

PTAL. I eliminated some generality that was no longer needed, and made the dart:blink stuff ...

6 years, 8 months ago (2014-04-25 00:38:03 UTC) #3

Leaf

6 years, 8 months ago (2014-04-25 16:22:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r35430 (presubmit successful).

Expand Messages | Collapse Messages