Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2544603003: Place CHECKs to check FontResource::startLoadLimiTimers is called appropriately (Closed)

Created:
4 years ago by yhirano
Modified:
4 years ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Place CHECKs to check FontResource::startLoadLimiTimers is called appropriately BUG=666227 Committed: https://crrev.com/2b57ae8716a7b6e19c1f9928c9c8a4551d472fb2 Cr-Commit-Position: refs/heads/master@{#435595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/loader/resource/FontResource.cpp View 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
yhirano
4 years ago (2016-12-01 07:40:03 UTC) #4
Takashi Toyoshima
lgtm.
4 years ago (2016-12-01 11:16:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544603003/1
4 years ago (2016-12-01 11:41:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 11:45:31 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2b57ae8716a7b6e19c1f9928c9c8a4551d472fb2 Cr-Commit-Position: refs/heads/master@{#435595}
4 years ago (2016-12-01 11:50:03 UTC) #13
Takashi Toyoshima
4 years ago (2016-12-02 11:10:50 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2549593005/ by toyoshim@chromium.org.

The reason for reverting is: Confirmed that the DCHECK at line 113 was wrong..

Powered by Google App Engine
This is Rietveld 408576698