[Android] Add '--gtest_also_run_disabled_tests' logic in gtest runner

build/android/pylib/local/device/local_device_gtest_run.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import itertools
 import logging
 import os
 import posixpath
 
@@ skipping 364 matching lines @@
     if self._test_instance.store_tombstones:
       tombstones.ClearAllTombstones(device)
     with device_temp_file.DeviceTempFile(
         adb=device.adb,
         dir=self._delegate.ResultsDirectory(device),
         suffix='.xml') as device_tmp_results_file:
 
       flags = self._test_instance.test_arguments or ''
       if self._test_instance.enable_xml_result_parsing:
         flags += ' --gtest_output=xml:%s' % device_tmp_results_file.name
+      flags += ' --gtest_also_run_disabled_tests'

[shenghuazhang, 2016/12/01 00:39:56]

I think this line is somehow necessary. When run gtest with
'--gtest_also_run_disabled_tests', all the 'DISABLED_' tests would come out as
FAILED if without this line. But those tests would pass if this line exists.

E.g. $build/android/test_runner.py  gtest -s ipc_tests
--gtest_also_run_disabled_tests

Result:

W    0.024s Main  No data dependencies will be pushed.
C   19.335s Main 
********************************************************************************
C   19.335s Main  Detailed Logs
C   19.335s Main 
********************************************************************************
C   19.336s Main 
********************************************************************************
C   19.336s Main  Summary
C   19.336s Main 
********************************************************************************
C   19.337s Main  [==========] 81 tests ran.
C   19.337s Main  [  PASSED  ] 72 tests.
C   19.337s Main  [  FAILED  ] 9 tests, listed below:
C   19.337s Main  [  FAILED  ] IPCMessageIntegrity.DISABLED_ReadVectorTooLarge1
(UNKNOWN)
C   19.337s Main  [  FAILED  ]
IPCMessageParameterTest.DISABLED_OneIntegerWithParam (UNKNOWN)
C   19.337s Main  [  FAILED  ]
IPCSyncChannelTest.DISABLED_ChannelDeleteDuringSend (UNKNOWN)
C   19.337s Main  [  FAILED  ] IPCSyncChannelTest.DISABLED_ChattyServer
(UNKNOWN)
C   19.337s Main  [  FAILED  ]
IPCSyncChannelTest.DISABLED_ChattyServerPumpDuringSend (UNKNOWN)
C   19.337s Main  [  FAILED  ] IPCSyncChannelTest.DISABLED_DoneEventRace
(UNKNOWN)
C   19.337s Main  [  FAILED  ]
IPCSyncChannelTest.DISABLED_RestrictedDispatch4WayDeadlock (UNKNOWN)
C   19.337s Main  [  FAILED  ] IPCSyncChannelTest.DISABLED_Simple (UNKNOWN)
C   19.337s Main  [  FAILED  ] MessageAttachmentSet.DISABLED_DontClose (UNKNOWN)
C   19.338s Main  
C   19.338s Main  9 FAILED TESTS
C   19.338s Main 
********************************************************************************

[jbudorick, 2016/12/01 00:44:48]

My point was just that we shouldn't add it all the time -- we ought to only add
it if gtest_also_run_disabled_tests is set.

[shenghuazhang, 2016/12/01 00:57:32]

KK I see :p

 
       output = self._delegate.Run(
           test, device, flags=flags,
           timeout=timeout, retries=0)
 
       if self._test_instance.enable_xml_result_parsing:
         gtest_xml = device.ReadFile(
             device_tmp_results_file.name,
             as_root=True)
 
@@ skipping 33 matching lines @@
   def TearDown(self):
     @local_device_environment.handle_shard_failures
     def individual_device_tear_down(dev):
       for s in self._servers.get(str(dev), []):
         s.TearDown()
 
       tool = self.GetTool(dev)
       tool.CleanUpEnvironment()
 
     self._env.parallel_devices.pMap(individual_device_tear_down)