Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2544533006: [Android] Add '--gtest_also_run_disabled_tests' for instrumentation tests (Closed)

Created:
4 years ago by shenghuazhang
Modified:
4 years ago
Reviewers:
jbudorick
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add '--gtest_also_run_disabled_tests' for instrumentation tests Add --gtest_also_run_disabled_tests in AddJavaTestOptions for test_runner.py. Add the run_disabled logic in instrumentation_test_instance.py. BUG=669632 Committed: https://crrev.com/7cd65ac511114dc5ee3ad8d392712ef66a76fdde Cr-Commit-Position: refs/heads/master@{#435842}

Patch Set 1 #

Total comments: 3

Patch Set 2 : john comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 1 1 chunk +4 lines, -3 lines 0 comments Download
M build/android/test_runner.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
shenghuazhang
4 years ago (2016-12-02 02:16:58 UTC) #3
jbudorick
https://codereview.chromium.org/2544533006/diff/1/build/android/pylib/instrumentation/instrumentation_test_instance.py File build/android/pylib/instrumentation/instrumentation_test_instance.py (right): https://codereview.chromium.org/2544533006/diff/1/build/android/pylib/instrumentation/instrumentation_test_instance.py#newcode556 build/android/pylib/instrumentation/instrumentation_test_instance.py:556: if not self._run_disabled: Without the property, we should be ...
4 years ago (2016-12-02 02:19:35 UTC) #4
shenghuazhang
Removed property '_run_disabled'. https://codereview.chromium.org/2544533006/diff/1/build/android/pylib/instrumentation/instrumentation_test_instance.py File build/android/pylib/instrumentation/instrumentation_test_instance.py (right): https://codereview.chromium.org/2544533006/diff/1/build/android/pylib/instrumentation/instrumentation_test_instance.py#newcode633 build/android/pylib/instrumentation/instrumentation_test_instance.py:633: def gtest_also_run_disabled_tests(self): On 2016/12/02 02:19:35, jbudorick ...
4 years ago (2016-12-02 02:25:40 UTC) #5
jbudorick
lgtm
4 years ago (2016-12-02 02:26:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544533006/20001
4 years ago (2016-12-02 02:28:07 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-02 03:30:45 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-02 03:32:30 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7cd65ac511114dc5ee3ad8d392712ef66a76fdde
Cr-Commit-Position: refs/heads/master@{#435842}

Powered by Google App Engine
This is Rietveld 408576698