|
|
Chromium Code Reviews
DescriptionRemove newly-added notification correctly in the message center
BUG=670060
TEST=manual tested
Committed: https://crrev.com/6aea3f6ecd4f2ced5ffdf88196ccb59e469723aa
Cr-Commit-Position: refs/heads/master@{#436641}
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== . BUG= ========== to ========== Remove newly-added notification correctly in the message center BUG=670060 TEST=manual tested ==========
yoshiki@chromium.org changed reviewers: + dewittj@chromium.org
Justin, PTAL.
Sorry abou tthe delay, was travelling earlier this week. Looking now.
I'd love to see a unit test for this case if possible. Code lg
On 2016/12/02 17:48:50, dewittj wrote: > I'd love to see a unit test for this case if possible. Code lg We don't have an unittest for MessageListView as for now. Let me do it separately: http://crbug.com/671495, http://crbug.com/671497
lgtm
The CQ bit was checked by yoshiki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481043818395600, "parent_rev":
"810c2dafdee8dfb6d49fc917c50a74d4757f5fdb", "commit_rev":
"2ff456a9f23b20ffc57b9442dbd4709a3ac7eaba"}
Message was sent while issue was closed.
Description was changed from ========== Remove newly-added notification correctly in the message center BUG=670060 TEST=manual tested ========== to ========== Remove newly-added notification correctly in the message center BUG=670060 TEST=manual tested ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove newly-added notification correctly in the message center BUG=670060 TEST=manual tested ========== to ========== Remove newly-added notification correctly in the message center BUG=670060 TEST=manual tested Committed: https://crrev.com/6aea3f6ecd4f2ced5ffdf88196ccb59e469723aa Cr-Commit-Position: refs/heads/master@{#436641} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6aea3f6ecd4f2ced5ffdf88196ccb59e469723aa Cr-Commit-Position: refs/heads/master@{#436641} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
