Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2544533005: Remove newly-added notification correctly in the message center (Closed)

Created:
4 years ago by yoshiki
Modified:
4 years ago
Reviewers:
dewittj
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove newly-added notification correctly in the message center BUG=670060 TEST=manual tested Committed: https://crrev.com/6aea3f6ecd4f2ced5ffdf88196ccb59e469723aa Cr-Commit-Position: refs/heads/master@{#436641}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M ui/message_center/views/message_list_view.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
yoshiki
Justin, PTAL.
4 years ago (2016-12-01 15:13:52 UTC) #7
dewittj
Sorry abou tthe delay, was travelling earlier this week. Looking now.
4 years ago (2016-12-02 17:41:39 UTC) #8
dewittj
I'd love to see a unit test for this case if possible. Code lg
4 years ago (2016-12-02 17:48:50 UTC) #9
yoshiki
On 2016/12/02 17:48:50, dewittj wrote: > I'd love to see a unit test for this ...
4 years ago (2016-12-06 05:03:50 UTC) #10
dewittj
lgtm
4 years ago (2016-12-06 16:52:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544533005/1
4 years ago (2016-12-06 17:04:16 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 18:04:51 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-06 18:06:51 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6aea3f6ecd4f2ced5ffdf88196ccb59e469723aa
Cr-Commit-Position: refs/heads/master@{#436641}

Powered by Google App Engine
This is Rietveld 408576698