Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: chrome/browser/android/offline_pages/request_coordinator_factory.cc

Issue 2544533003: [OfflinePages] Hook the background loader offliner to the request coordinator based on finch flag s… (Closed)
Patch Set: sort includes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/request_coordinator_factory.cc
diff --git a/chrome/browser/android/offline_pages/request_coordinator_factory.cc b/chrome/browser/android/offline_pages/request_coordinator_factory.cc
index a4b0244f19b1509fe385587955a943f80f8881e7..d68fb734e6695e5f75bd7881439ad78b3a8892e5 100644
--- a/chrome/browser/android/offline_pages/request_coordinator_factory.cc
+++ b/chrome/browser/android/offline_pages/request_coordinator_factory.cc
@@ -9,6 +9,7 @@
#include "base/memory/ptr_util.h"
#include "base/memory/singleton.h"
#include "base/sequenced_task_runner.h"
+#include "chrome/browser/android/offline_pages/background_loader_offliner_factory.h"
#include "chrome/browser/android/offline_pages/background_scheduler_bridge.h"
#include "chrome/browser/android/offline_pages/downloads/offline_page_notification_bridge.h"
#include "chrome/browser/android/offline_pages/prerendering_offliner_factory.h"
@@ -25,6 +26,7 @@
#include "components/offline_pages/core/background/request_queue_store_sql.h"
#include "components/offline_pages/core/background/scheduler.h"
#include "components/offline_pages/core/downloads/download_notifying_observer.h"
+#include "components/offline_pages/core/offline_page_feature.h"
#include "content/public/browser/browser_thread.h"
#include "net/nqe/network_quality_estimator.h"
@@ -50,8 +52,14 @@ RequestCoordinator* RequestCoordinatorFactory::GetForBrowserContext(
KeyedService* RequestCoordinatorFactory::BuildServiceInstanceFor(
content::BrowserContext* context) const {
std::unique_ptr<OfflinerPolicy> policy(new OfflinerPolicy());
- std::unique_ptr<OfflinerFactory> prerenderer_offliner(
- new PrerenderingOfflinerFactory(context));
+ std::unique_ptr<OfflinerFactory> offliner;
+
+ // Determines which offliner to use based on flag.
+ if (ShouldUseNewBackgroundLoader()) {
+ offliner.reset(new BackgroundLoaderOfflinerFactory(context));
+ } else {
+ offliner.reset(new PrerenderingOfflinerFactory(context));
+ }
scoped_refptr<base::SequencedTaskRunner> background_task_runner =
content::BrowserThread::GetBlockingPool()->GetSequencedTaskRunner(
@@ -71,7 +79,7 @@ KeyedService* RequestCoordinatorFactory::BuildServiceInstanceFor(
// TODO(fgorski): Something needs to keep the handle to the Notification
// dispatcher.
RequestCoordinator* request_coordinator = new RequestCoordinator(
- std::move(policy), std::move(prerenderer_offliner), std::move(queue),
+ std::move(policy), std::move(offliner), std::move(queue),
std::move(scheduler), network_quality_estimator);
DownloadNotifyingObserver::CreateAndStartObserving(

Powered by Google App Engine
This is Rietveld 408576698