components/webcrypto/algorithms/ec.cc - Issue 2544533002: Have all overloads of webcrypto::AlgorithmImplementation::DeserializeKeyForClone check the params t…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/webcrypto/algorithms/ec.cc

Issue 2544533002: Have all overloads of webcrypto::AlgorithmImplementation::DeserializeKeyForClone check the params t… (Closed)

Patch Set: add a test for a case similar to the one the fuzzer found Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/webcrypto/algorithms/ec.cc

diff --git a/components/webcrypto/algorithms/ec.cc b/components/webcrypto/algorithms/ec.cc

index 1436ad19b57b64ccd95ed1385af568881230e5cb..2a6d312de3a65d3046511e55e53b419b2051df76 100644

--- a/components/webcrypto/algorithms/ec.cc

+++ b/components/webcrypto/algorithms/ec.cc

@@ -656,6 +656,9 @@ Status EcAlgorithm::DeserializeKeyForClone(

blink::WebCryptoKeyUsageMask usages,

const CryptoData& key_data,

blink::WebCryptoKey* key) const {

+ if (algorithm.paramsType() != blink::WebCryptoKeyAlgorithmParamsTypeEc)

+ return Status::ErrorUnexpected();

blink::WebCryptoAlgorithm import_algorithm =

SynthesizeImportAlgorithmForClone(algorithm);