Have all overloads of webcrypto::AlgorithmImplementation::DeserializeKeyForClone check the params t…

components/webcrypto/algorithms/pbkdf2.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 
 #include "base/memory/ptr_util.h"
 #include "base/stl_util.h"
 #include "components/webcrypto/algorithm_implementation.h"
 #include "components/webcrypto/algorithms/secret_key_util.h"
@@ skipping 92 matching lines @@
     }
     return Status::Success();
   }
 
   Status DeserializeKeyForClone(const blink::WebCryptoKeyAlgorithm& algorithm,
                                 blink::WebCryptoKeyType type,
                                 bool extractable,
                                 blink::WebCryptoKeyUsageMask usages,
                                 const CryptoData& key_data,
                                 blink::WebCryptoKey* key) const override {
+    if (algorithm.paramsType() != blink::WebCryptoKeyAlgorithmParamsTypeNone)
+      return Status::ErrorUnexpected();
+

[eroman, 2016/11/30 19:15:50]

Can you also add a test for:
   type == WebCryptoKeyTypeSecret

     // NOTE: Unlike ImportKeyRaw(), this does not enforce extractable==false.
     // This is intentional. Although keys cannot currently be created with
     // extractable==true, earlier implementations permitted this, so
     // de-serialization by structured clone should not reject them.
     return CreateWebCryptoSecretKey(key_data, algorithm, extractable, usages,
                                     key);
   }
 
   Status GetKeyLength(const blink::WebCryptoAlgorithm& key_length_algorithm,
                       bool* has_length_bits,
                       unsigned int* length_bits) const override {
     *has_length_bits = false;
     return Status::Success();
   }
 };
 
 }  // namespace
 
 std::unique_ptr<AlgorithmImplementation> CreatePbkdf2Implementation() {
   return base::WrapUnique(new Pbkdf2Implementation);
 }
 
 }  // namespace webcrypto