Have all overloads of webcrypto::AlgorithmImplementation::DeserializeKeyForClone check the params t…

components/webcrypto/algorithms/hmac.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/numerics/safe_math.h"
@@ skipping 273 matching lines @@
 
     return Status::Success();
   }
 
   Status DeserializeKeyForClone(const blink::WebCryptoKeyAlgorithm& algorithm,
                                 blink::WebCryptoKeyType type,
                                 bool extractable,
                                 blink::WebCryptoKeyUsageMask usages,
                                 const CryptoData& key_data,
                                 blink::WebCryptoKey* key) const override {
+    if (algorithm.paramsType() != blink::WebCryptoKeyAlgorithmParamsTypeHmac)
+      return Status::ErrorUnexpected();
+

[eroman, 2016/11/30 19:15:50]

Can you also add a test for:
   type == WebCryptoKeyTypeSecret

     return CreateWebCryptoSecretKey(key_data, algorithm, extractable, usages,
                                     key);
   }
 
   Status GetKeyLength(const blink::WebCryptoAlgorithm& key_length_algorithm,
                       bool* has_length_bits,
                       unsigned int* length_bits) const override {
     const blink::WebCryptoHmacImportParams* params =
         key_length_algorithm.hmacImportParams();
 
     *has_length_bits = true;
     if (params->hasLengthBits()) {
       *length_bits = params->optionalLengthBits();
       if (*length_bits == 0)
         return Status::ErrorGetHmacKeyLengthZero();
       return Status::Success();
     }
 
     return GetDigestBlockSizeBits(params->hash(), length_bits);
   }
 };
 
 }  // namespace
 
 std::unique_ptr<AlgorithmImplementation> CreateHmacImplementation() {
   return base::WrapUnique(new HmacImplementation);
 }
 
 }  // namespace webcrypto