Have all overloads of webcrypto::AlgorithmImplementation::DeserializeKeyForClone check the params t…

components/webcrypto/algorithms/aes.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/webcrypto/algorithms/aes.h"
 
 #include <stddef.h>
 
 #include "base/logging.h"
 #include "components/webcrypto/algorithms/secret_key_util.h"
@@ skipping 181 matching lines @@
   return Status::Success();
 }
 
 Status AesAlgorithm::DeserializeKeyForClone(
     const blink::WebCryptoKeyAlgorithm& algorithm,
     blink::WebCryptoKeyType type,
     bool extractable,
     blink::WebCryptoKeyUsageMask usages,
     const CryptoData& key_data,
     blink::WebCryptoKey* key) const {
+  if (algorithm.paramsType() != blink::WebCryptoKeyAlgorithmParamsTypeAes)
+    return Status::ErrorUnexpected();
+

[eroman, 2016/11/30 19:15:50]

Can you also add a test for
  type == WebCryptoKeyTypeSecret

   return ImportKeyRaw(key_data, SynthesizeImportAlgorithmForClone(algorithm),
                       extractable, usages, key);
 }
 
 Status AesAlgorithm::GetKeyLength(
     const blink::WebCryptoAlgorithm& key_length_algorithm,
     bool* has_length_bits,
     unsigned int* length_bits) const {
   *has_length_bits = true;
   *length_bits = key_length_algorithm.aesDerivedKeyParams()->lengthBits();
 
   if (*length_bits == 128 || *length_bits == 256)
     return Status::Success();
 
   // 192-bit AES is intentionally unsupported (http://crbug.com/533699).
   if (*length_bits == 192)
     return Status::ErrorAes192BitUnsupported();
 
   return Status::ErrorGetAesKeyLength();
 }
 
 }  // namespace webcrypto