Chromium Code Reviews| Index: media/mojo/services/mojo_media_client.h |
| diff --git a/media/mojo/services/mojo_media_client.h b/media/mojo/services/mojo_media_client.h |
| index c6020662013bf40fa2b02c12d4854d299b32c934..13f69eccb942b1f6a7f1899cab1aa47c9744175c 100644 |
| --- a/media/mojo/services/mojo_media_client.h |
| +++ b/media/mojo/services/mojo_media_client.h |
| @@ -16,6 +16,7 @@ class SingleThreadTaskRunner; |
| } |
| namespace service_manager { |
| +class Connector; |
| namespace mojom { |
| class InterfaceProvider; |
| } |
| @@ -38,8 +39,9 @@ class MEDIA_MOJO_EXPORT MojoMediaClient { |
| // up tasks requiring the message loop must be completed before returning. |
| virtual ~MojoMediaClient(); |
| - // Called exactly once before any other method. |
| - virtual void Initialize(); |
| + // Called exactly once before any other method. |connector| can be used by |
| + // this to connect to other services. It is guaranteed to outlive this. |
|
xhwang
2016/11/30 18:49:31
s/this/|this|
slan
2016/12/01 00:47:22
Done.
|
| + virtual void Initialize(service_manager::Connector* connector); |
| virtual std::unique_ptr<AudioDecoder> CreateAudioDecoder( |
| scoped_refptr<base::SingleThreadTaskRunner> task_runner); |
| @@ -61,7 +63,9 @@ class MEDIA_MOJO_EXPORT MojoMediaClient { |
| virtual std::unique_ptr<RendererFactory> CreateRendererFactory( |
| const scoped_refptr<MediaLog>& media_log); |
| - // Returns the CdmFactory to be used by MojoCdmService. |
| + // Returns the CdmFactory to be used by MojoCdmService. |interface_provider| |
| + // can be used to request interfaces provided by the remote client. It may be |
|
xhwang
2016/11/30 18:49:31
s/by the remote client/remotely?
In chrome, the i
slan
2016/12/01 00:47:22
Yes, I like this phrasing. Done.
|
| + // a nullptr if the client chose not to bind the InterfacePtr. |
| virtual std::unique_ptr<CdmFactory> CreateCdmFactory( |
| service_manager::mojom::InterfaceProvider* interface_provider); |