media/mojo/services/media_manifest.json - Issue 2544523002: Pass Connector* into MojoMediaClient::Initialize().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/mojo/services/media_manifest.json

Issue 2544523002: Pass Connector* into MojoMediaClient::Initialize(). (Closed)

Patch Set: Rebase. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 {	1 {

2 "name": "media",	2 "name": "media",

3 "display_name": "Media Service",	3 "display_name": "Media Service",

4 "interface_provider_specs": {	4 "interface_provider_specs": {

5 "service_manager:connector": {	5 "service_manager:connector": {

6 "provides": {	6 "provides": {

7 "media:media": [ "media::mojom::MediaService" ],	7 "media:media": [ "media::mojom::MediaService" ]
	xhwang 2016/11/30 18:49:31 FYI, we have some very broken test that actually u FYI, we have some very broken test that actually uses media:interface_factory. I am fixing those tests so your change lg. slan 2016/12/01 00:47:22 Acknowledged. Show quoted text On 2016/11/30 18:49:31, xhwang wrote: > FYI, we have some very broken test that actually uses media:interface_factory. I > am fixing those tests so your change lg. Acknowledged.
8 "media:interface_factory": [ "media::mojom::InterfaceFactory" ]

9 },	8 },

10 "requires": {	9 "requires": {

11 "*": [ "app" ]	10 "*": [ "app" ]

12 }	11 }

13 }	12 }

14 }	13 }

15 }	14 }

OLD	NEW