third_party/WebKit/LayoutTests/bluetooth/characteristic/characteristicProperties.html - Issue 2544513004: Fix WebBluetooth generator to distinguish between different methods.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/characteristic/characteristicProperties.html

Issue 2544513004: Fix WebBluetooth generator to distinguish between different methods. (Closed)

Patch Set: fixes to address comments from ortuno Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/bluetooth/README ('K') | « third_party/WebKit/LayoutTests/bluetooth/README ('k') | third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/add-listener-after-promise.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../resources/testharness.js"></script>	2 <script src="../../resources/testharness.js"></script>

3 <script src="../resources/testharnessreport.js"></script>	3 <script src="../../resources/testharnessreport.js"></script>

4 <script src="../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

5 <script>	5 <script>

6 'use strict';	6 'use strict';

7 test(t => { assert_true(window.testRunner instanceof Object); t.done(); },	7 test(t => { assert_true(window.testRunner instanceof Object); t.done(); },

8 'window.testRunner is required for the following tests.');	8 'window.testRunner is required for the following tests.');

9	9

10 promise_test(() => {	10 promise_test(() => {

11 return setBluetoothFakeAdapter('HeartRateAdapter')	11 return setBluetoothFakeAdapter('HeartRateAdapter')

12 .then(() => requestDeviceWithKeyDown({	12 .then(() => requestDeviceWithKeyDown({

13 filters: [{services: ['heart_rate']}]}))	13 filters: [{services: ['heart_rate']}]}))

14 .then(device => device.gatt.connect())	14 .then(device => device.gatt.connect())

15 .then(gattServer => gattServer.getPrimaryService('heart_rate'))	15 .then(gattServer => gattServer.getPrimaryService('heart_rate'))

16 .then(service => {	16 .then(service => {

17 return Promise.all([service.getCharacteristic('body_sensor_location'),	17 return Promise.all([service.getCharacteristic('body_sensor_location'),

18 service.getCharacteristic('heart_rate_measurement')]);	18 service.getCharacteristic('heart_rate_measurement')]);

19 }).then(characteristics => {	19 }).then(characteristics => {

20 let bsl_properties = characteristics[0].properties;	20 let bsl_properties = characteristics[0].properties;

21 let bsl_expected_properties = new TestCharacteristicProperties({read: true });	21 let bsl_expected_properties = new TestCharacteristicProperties({read: true });

22 assert_properties_equal(bsl_properties, bsl_expected_properties);	22 assert_properties_equal(bsl_properties, bsl_expected_properties);

23	23

24 let hrm_properties = characteristics[1].properties;	24 let hrm_properties = characteristics[1].properties;

25 let hrm_expected_properties = new TestCharacteristicProperties({notify: tr ue});	25 let hrm_expected_properties = new TestCharacteristicProperties({notify: tr ue});

26 assert_properties_equal(hrm_properties, hrm_expected_properties);	26 assert_properties_equal(hrm_properties, hrm_expected_properties);

27 });	27 });

28 }, 'HeartRate device properties');	28 }, 'HeartRate device properties');

29 </script>	29 </script>

OLD	NEW