third_party/WebKit/LayoutTests/bluetooth/device/gattserverdisconnected-event/disconnected_gc.html - Issue 2544513004: Fix WebBluetooth generator to distinguish between different methods.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/device/gattserverdisconnected-event/disconnected_gc.html

Issue 2544513004: Fix WebBluetooth generator to distinguish between different methods. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/device/gattserverdisconnected-event/disconnected.html ('k') | third_party/WebKit/LayoutTests/bluetooth/device/gattserverdisconnected-event/one-event-per-disconnection.html » ('j') | third_party/WebKit/LayoutTests/bluetooth/generate.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/testharness.js"></script>	2 <script src="../../../resources/testharness.js"></script>

3 <script src="../../resources/testharnessreport.js"></script>	3 <script src="../../../resources/testharnessreport.js"></script>

4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

5 <script>	5 <script>

6 'use strict';	6 'use strict';

7 promise_test(t => {	7 promise_test(t => {

8 return setBluetoothFakeAdapter('DisconnectingHeartRateAdapter')	8 return setBluetoothFakeAdapter('DisconnectingHeartRateAdapter')

9 .then(() => requestDeviceWithKeyDown({	9 .then(() => requestDeviceWithKeyDown({

10 filters: [{services: ['heart_rate']}],	10 filters: [{services: ['heart_rate']}],

11 optionalServices: [request_disconnection_service_uuid]	11 optionalServices: [request_disconnection_service_uuid]

12 }))	12 }))

13 .then(device => device.gatt.connect())	13 .then(device => device.gatt.connect())

14 .then(gattServer => get_request_disconnection(gattServer))	14 .then(gattServer => get_request_disconnection(gattServer))

15 .then(requestDisconnection => {	15 .then(requestDisconnection => {

16 requestDisconnection();	16 requestDisconnection();

17 requestDisconnection = undefined;	17 requestDisconnection = undefined;

18 return runGarbageCollection();	18 return runGarbageCollection();

19 // Wait 50ms after the GC runs for the disconnection event to come back.	19 // Wait 50ms after the GC runs for the disconnection event to come back.

20 // There's nothing to assert other than that only valid memory is used.	20 // There's nothing to assert other than that only valid memory is used.

21 }).then(() => new Promise(resolve => setTimeout(resolve, 50)));	21 }).then(() => new Promise(resolve => setTimeout(resolve, 50)));

22 }, 'A device disconnecting after the BluetoothDevice object has been gced ' +	22 }, 'A device disconnecting after the BluetoothDevice object has been gced ' +

23 'should not access freed memory.');	23 'should not access freed memory.');

24 </script>	24 </script>

OLD	NEW