Remove android build dir nesting restriction

Remove android build dir nesting restriction

It appears that android builds no longer have to be nested exactly two
levels under //. A build with one level works, so the assert in gn is
no longer helpful.

BUG=412935
R=agrieve@chromium.org

Committed: https://crrev.com/77a846f5c24714f5cde96d6e3fd124d501206799
Cr-Commit-Position: refs/heads/master@{#435410}

[tsniatowski, 2016-11-30 10:57:46]

PTAL: gn gen outa --args="target_os=\"android\"" && ninja -C outa just worked
for me after this.

[agrieve, 2016-11-30 14:57:59]

On 2016/11/30 10:57:46, tsniatowski wrote:
> PTAL: gn gen outa --args="target_os=\"android\"" && ninja -C outa just worked
> for me after this.

Could you please clarify what you tested to say that it now works? E.g. I'd try
running "ninja" without args to build all targets, and also confirm that one or
two tests within base_unittests and chrome_public_test_apk run.

[tsniatowski, 2016-11-30 15:01:33]

On 2016/11/30 14:57:59, agrieve wrote:
> On 2016/11/30 10:57:46, tsniatowski wrote:
> > PTAL: gn gen outa --args="target_os=\"android\"" && ninja -C outa just
worked
> > for me after this.
> 
> Could you please clarify what you tested to say that it now works? E.g. I'd
try
> running "ninja" without args to build all targets, and also confirm that one
or
> two tests within base_unittests and chrome_public_test_apk run.

I meant that a plain "ninja" without args works when the outdir is nested one
level below //, all targets build.

Getting a test run will take me a while, no env right now, will get back to you
in a couple hours.

[agrieve, 2016-11-30 15:25:30]

On 2016/11/30 15:01:33, tsniatowski wrote:
> On 2016/11/30 14:57:59, agrieve wrote:
> > On 2016/11/30 10:57:46, tsniatowski wrote:
> > > PTAL: gn gen outa --args="target_os=\"android\"" && ninja -C outa just
> worked
> > > for me after this.
> > 
> > Could you please clarify what you tested to say that it now works? E.g. I'd
> try
> > running "ninja" without args to build all targets, and also confirm that one
> or
> > two tests within base_unittests and chrome_public_test_apk run.
> 
> I meant that a plain "ninja" without args works when the outdir is nested one
> level below //, all targets build.
That's encouraging! 

> 
> Getting a test run will take me a while, no env right now, will get back to
you
> in a couple hours.

Great! Don't need to run the whole suites. Just want to make sure the
file-pushing logic in the test runner works. It was actually re-written
recently, so there's a decent chance it'll work now.

[tsniatowski, 2016-11-30 19:51:14]

On 2016/11/30 15:25:30, agrieve wrote:
> On 2016/11/30 15:01:33, tsniatowski wrote:
> > On 2016/11/30 14:57:59, agrieve wrote:
> > > On 2016/11/30 10:57:46, tsniatowski wrote:
> > > > PTAL: gn gen outa --args="target_os=\"android\"" && ninja -C outa just
> > worked
> > > > for me after this.
> > > 
> > > Could you please clarify what you tested to say that it now works? E.g.
I'd
> > try
> > > running "ninja" without args to build all targets, and also confirm that
one
> > or
> > > two tests within base_unittests and chrome_public_test_apk run.
> > 
> > I meant that a plain "ninja" without args works when the outdir is nested
one
> > level below //, all targets build.
> That's encouraging! 
> 
> > 
> > Getting a test run will take me a while, no env right now, will get back to
> you
> > in a couple hours.
> 
> Great! Don't need to run the whole suites. Just want to make sure the
> file-pushing logic in the test runner works. It was actually re-written
> recently, so there's a decent chance it'll work now.

after some wrestling with device setup (teh scripts seem very adb server restart
happy, but whatever):

$ outa/bin/run_base_unittests
C  106.704s Main 
********************************************************************************
C  106.704s Main  Summary
C  106.704s Main 
********************************************************************************
C  106.710s Main  [==========] 2146 tests ran.
C  106.710s Main  [  PASSED  ] 2146 tests.
C  106.710s Main 
********************************************************************************

An initial (aborted) run of outa/bin/run_chrome_public_test_apk was going well
as far as setup goes, but not 100% in actual tests; looking at the waterfall
this tends to be not-100% often. I left it running, it looks like it'll take a
while.

[agrieve, 2016-11-30 19:53:29]

On 2016/11/30 19:51:14, tsniatowski wrote:
> On 2016/11/30 15:25:30, agrieve wrote:
> > On 2016/11/30 15:01:33, tsniatowski wrote:
> > > On 2016/11/30 14:57:59, agrieve wrote:
> > > > On 2016/11/30 10:57:46, tsniatowski wrote:
> > > > > PTAL: gn gen outa --args="target_os=\"android\"" && ninja -C outa just
> > > worked
> > > > > for me after this.
> > > > 
> > > > Could you please clarify what you tested to say that it now works? E.g.
> I'd
> > > try
> > > > running "ninja" without args to build all targets, and also confirm that
> one
> > > or
> > > > two tests within base_unittests and chrome_public_test_apk run.
> > > 
> > > I meant that a plain "ninja" without args works when the outdir is nested
> one
> > > level below //, all targets build.
> > That's encouraging! 
> > 
> > > 
> > > Getting a test run will take me a while, no env right now, will get back
to
> > you
> > > in a couple hours.
> > 
> > Great! Don't need to run the whole suites. Just want to make sure the
> > file-pushing logic in the test runner works. It was actually re-written
> > recently, so there's a decent chance it'll work now.
> 
> after some wrestling with device setup (teh scripts seem very adb server
restart
> happy, but whatever):
> 
> $ outa/bin/run_base_unittests
> C  106.704s Main 
>
********************************************************************************
> C  106.704s Main  Summary
> C  106.704s Main 
>
********************************************************************************
> C  106.710s Main  [==========] 2146 tests ran.
> C  106.710s Main  [  PASSED  ] 2146 tests.
> C  106.710s Main 
>
********************************************************************************
> 
> An initial (aborted) run of outa/bin/run_chrome_public_test_apk was going well
> as far as setup goes, but not 100% in actual tests; looking at the waterfall
> this tends to be not-100% often. I left it running, it looks like it'll take a
> while.

That's great! lgtm then! Running all the tests locally takes a very long time
and often flakes. If there was a problem, you'd notice pretty quick :)

[tsniatowski, 2016-11-30 19:54:29]

The CQ bit was checked by tsniatowski@opera.com

[commit-bot: I haz the power, 2016-11-30 19:55:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 20:54:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480535669648630, "parent_rev":
"bd494929eb9caa7d77ad2a3fb468afa8e406dc4e", "commit_rev":
"914c481874bb50581c1bf59d84733bf2617a2a1c"}

[commit-bot: I haz the power, 2016-11-30 20:55:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-30 21:03:50]

Description was changed from

==========
Remove android build dir nesting restriction

It appears that android builds no longer have to be nested exactly two
levels under //. A build with one level works, so the assert in gn is
no longer helpful.

BUG=412935
R=agrieve@chromium.org
==========

to

==========
Remove android build dir nesting restriction

It appears that android builds no longer have to be nested exactly two
levels under //. A build with one level works, so the assert in gn is
no longer helpful.

BUG=412935
R=agrieve@chromium.org

Committed: https://crrev.com/77a846f5c24714f5cde96d6e3fd124d501206799
Cr-Commit-Position: refs/heads/master@{#435410}
==========

[commit-bot: I haz the power, 2016-11-30 21:03:51]

Patchset 1 (id:??) landed as
https://crrev.com/77a846f5c24714f5cde96d6e3fd124d501206799
Cr-Commit-Position: refs/heads/master@{#435410}