Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2544493002: Remove android build dir nesting restriction (Closed)

Created:
4 years ago by tsniatowski
Modified:
4 years ago
Reviewers:
agrieve
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove android build dir nesting restriction It appears that android builds no longer have to be nested exactly two levels under //. A build with one level works, so the assert in gn is no longer helpful. BUG=412935 R=agrieve@chromium.org Committed: https://crrev.com/77a846f5c24714f5cde96d6e3fd124d501206799 Cr-Commit-Position: refs/heads/master@{#435410}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build/config/android/config.gni View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
tsniatowski
PTAL: gn gen outa --args="target_os=\"android\"" && ninja -C outa just worked for me after this.
4 years ago (2016-11-30 10:57:46 UTC) #1
agrieve
On 2016/11/30 10:57:46, tsniatowski wrote: > PTAL: gn gen outa --args="target_os=\"android\"" && ninja -C outa ...
4 years ago (2016-11-30 14:57:59 UTC) #2
tsniatowski
On 2016/11/30 14:57:59, agrieve wrote: > On 2016/11/30 10:57:46, tsniatowski wrote: > > PTAL: gn ...
4 years ago (2016-11-30 15:01:33 UTC) #3
agrieve
On 2016/11/30 15:01:33, tsniatowski wrote: > On 2016/11/30 14:57:59, agrieve wrote: > > On 2016/11/30 ...
4 years ago (2016-11-30 15:25:30 UTC) #4
tsniatowski
On 2016/11/30 15:25:30, agrieve wrote: > On 2016/11/30 15:01:33, tsniatowski wrote: > > On 2016/11/30 ...
4 years ago (2016-11-30 19:51:14 UTC) #5
agrieve
On 2016/11/30 19:51:14, tsniatowski wrote: > On 2016/11/30 15:25:30, agrieve wrote: > > On 2016/11/30 ...
4 years ago (2016-11-30 19:53:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544493002/1
4 years ago (2016-11-30 19:55:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 20:55:17 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-30 21:03:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77a846f5c24714f5cde96d6e3fd124d501206799
Cr-Commit-Position: refs/heads/master@{#435410}

Powered by Google App Engine
This is Rietveld 408576698