Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2544443002: Add a comment that CHECK should not be used until the performance issue is fixed. (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
napper, sashab
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a comment that CHECK should not be used until the performance issue is fixed. BUG=596760 Committed: https://crrev.com/67f3e693b8b02c8a7b2fc15f12e985924cf539a7 Cr-Commit-Position: refs/heads/master@{#435197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/wtf/Assertions.h View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
haraken
PTAL
4 years ago (2016-11-30 07:26:08 UTC) #3
sashab
lgtm
4 years ago (2016-11-30 07:31:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544443002/1
4 years ago (2016-11-30 07:32:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 09:21:30 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/67f3e693b8b02c8a7b2fc15f12e985924cf539a7 Cr-Commit-Position: refs/heads/master@{#435197}
4 years ago (2016-11-30 09:24:32 UTC) #11
napper
4 years ago (2016-11-30 23:08:31 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698