Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1456)

Issue 2544413002: [ios] Adds settings and stack_view resources (Closed)

Created:
4 years ago by sczs1
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds settings and stack_view resources BUG=666732 Committed: https://crrev.com/be7b7770d25e1ecc982a04a909a412be4208fbb0 Cr-Commit-Position: refs/heads/master@{#436138}

Patch Set 1 #

Patch Set 2 : Remove unused images #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
A ios/chrome/browser/ui/settings/BUILD.gn View 1 chunk +26 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/resources/app_icon_placeholder.png View Binary file 0 comments Download
A ios/chrome/browser/ui/settings/resources/app_icon_placeholder@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/settings/resources/app_icon_placeholder@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/settings/resources/encryption_error.png View Binary file 0 comments Download
A ios/chrome/browser/ui/settings/resources/encryption_error@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/settings/resources/encryption_error@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/settings/resources/settings_accounts_add_account.png View Binary file 0 comments Download
A ios/chrome/browser/ui/settings/resources/settings_accounts_add_account@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/settings/resources/settings_accounts_add_account@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/settings/resources/settings_error.png View Binary file 0 comments Download
A ios/chrome/browser/ui/settings/resources/settings_error@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/settings/resources/settings_error@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/settings/resources/settings_sync.png View Binary file 0 comments Download
A ios/chrome/browser/ui/settings/resources/settings_sync@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/settings/resources/settings_sync@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/BUILD.gn View 1 chunk +52 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_bottom.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_bottom@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_bottom@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_bottom.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_bottom@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_bottom@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_left.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_left@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_left@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_right.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_right@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_right@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_top.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_top@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_incognito_top@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_left.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_left@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_left@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_right.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_right@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_right@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_top.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_top@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/border_frame_top@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/card_close_button.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/card_close_button@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/card_close_button@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/card_close_button_incognito.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/card_close_button_incognito@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/card_close_button_incognito@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/card_close_button_pressed.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/card_close_button_pressed@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/card_close_button_pressed@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/card_frame_shadow.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/card_frame_shadow@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/card_frame_shadow@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/stack_view_background_noise.jpg View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/stack_view_background_noise@2x.jpg View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/stack_view_background_noise@2x~ipad.jpg View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/stack_view_background_noise@3x.jpg View Binary file 0 comments Download
A ios/chrome/browser/ui/stack_view/resources/stack_view_background_noise~ipad.jpg View Binary file 0 comments Download

Messages

Total messages: 11 (4 generated)
sczs1
PTAL
4 years ago (2016-12-02 21:19:20 UTC) #2
rohitrao (ping after 24h)
card_closed_button_pressed_incognito is not in the BUILD.gn file, so let's remove those three images from the ...
4 years ago (2016-12-02 21:27:40 UTC) #3
sczs1
On 2016/12/02 21:27:40, rohitrao wrote: > card_closed_button_pressed_incognito is not in the BUILD.gn file, so let's ...
4 years ago (2016-12-02 23:06:22 UTC) #4
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-02 23:31:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544413002/20001
4 years ago (2016-12-02 23:32:47 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-03 02:20:02 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-03 02:23:52 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/be7b7770d25e1ecc982a04a909a412be4208fbb0
Cr-Commit-Position: refs/heads/master@{#436138}

Powered by Google App Engine
This is Rietveld 408576698