Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2544353002: Roll third_party/inspector_protocol to c65b17da8a32bc6ab25b4ebbef1008f23c69e7d1. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll third_party/inspector_protocol to c65b17da8a32bc6ab25b4ebbef1008f23c69e7d1. Roll includes: - [inspector_protocol] Move imported/exported information to config options. - [inspector_protocol] Restructure generator code. BUG=664683 Committed: https://crrev.com/64a188e2b27be066f7e3b56b1a8debcbe83f7dbb Cr-Commit-Position: refs/heads/master@{#436064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -286 lines) Patch
M third_party/WebKit/Source/core/inspector/inspector_protocol_config.json View 1 chunk +11 lines, -1 line 0 comments Download
M third_party/inspector_protocol/CodeGenerator.py View 6 chunks +184 lines, -197 lines 0 comments Download
M third_party/inspector_protocol/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/inspector_protocol/templates/Exported_h.template View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/inspector_protocol/templates/Imported_h.template View 1 chunk +1 line, -1 line 0 comments Download
M third_party/inspector_protocol/templates/TypeBuilder_cpp.template View 15 chunks +51 lines, -47 lines 0 comments Download
M third_party/inspector_protocol/templates/TypeBuilder_h.template View 10 chunks +40 lines, -36 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dgozman
Take a look please.
4 years ago (2016-12-02 19:01:58 UTC) #2
kozy
lgtm
4 years ago (2016-12-02 19:02:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544353002/1
4 years ago (2016-12-02 22:44:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 22:50:18 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-02 22:52:53 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64a188e2b27be066f7e3b56b1a8debcbe83f7dbb
Cr-Commit-Position: refs/heads/master@{#436064}

Powered by Google App Engine
This is Rietveld 408576698