Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: net/spdy/spdy_session.cc

Issue 2544343003: Use wire values in SpdySettingsIds. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_protocol_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index 37f3c525ad3a5169f585daff955abb12264897af..bbb754137c942d5792f363368fd06236dca8f6c2 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -144,7 +144,7 @@ std::unique_ptr<base::Value> NetLogSpdySettingCallback(
uint32_t value,
NetLogCaptureMode /* capture_mode */) {
std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
- dict->SetInteger("id", SpdyConstants::SerializeSettingId(id));
+ dict->SetInteger("id", id);
dict->SetInteger("flags", flags);
dict->SetInteger("value", value);
return std::move(dict);
@@ -160,9 +160,8 @@ std::unique_ptr<base::Value> NetLogSpdySendSettingsCallback(
const SpdySettingsIds id = it->first;
const SpdySettingsFlags flags = it->second.first;
const uint32_t value = it->second.second;
- settings_list->AppendString(base::StringPrintf(
- "[id:%u flags:%u value:%u]", SpdyConstants::SerializeSettingId(id),
- flags, value));
+ settings_list->AppendString(
+ base::StringPrintf("[id:%u flags:%u value:%u]", id, flags, value));
}
dict->Set("settings", std::move(settings_list));
return std::move(dict);
« no previous file with comments | « net/spdy/spdy_protocol_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698