Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2544343003: Use wire values in SpdySettingsIds. (Closed)

Created:
4 years ago by Bence
Modified:
4 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use wire values in SpdySettingsIds. - Use wire values in SpdySettingsIds, - remove SPDY/3.1-only setting values from SpdySettingsIds, - rename ParseSettingId() to ParseSettingsId(), - merge IsValidSettingId() into ParseSettingsId(), - remove SerializeSettingId(), - factor out SettingsIdToString(); remove default case to make sure every enum value is handled. These values are not persisted to disk (that was a SPDY/3.1 feature), so the only downside to the value change is Chrome net-log incompatibility. This lands server side change 140592266 by bnc. BUG=622737, 488484 Committed: https://crrev.com/08e5b8e42482ea6f11711333306df76c8ff24d80 Cr-Commit-Position: refs/heads/master@{#436200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -96 lines) Patch
M net/quic/core/quic_headers_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_framer.cc View 2 chunks +8 lines, -13 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M net/spdy/spdy_protocol.h View 2 chunks +17 lines, -29 lines 0 comments Download
M net/spdy/spdy_protocol.cc View 1 chunk +24 lines, -34 lines 0 comments Download
M net/spdy/spdy_protocol_test.cc View 3 chunks +46 lines, -3 lines 0 comments Download
M net/spdy/spdy_session.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Bence
Ryan: PTAL. Thank you.
4 years ago (2016-12-03 00:20:27 UTC) #6
Ryan Hamilton
lgtm
4 years ago (2016-12-04 18:03:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544343003/1
4 years ago (2016-12-04 18:04:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-04 19:48:40 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-04 19:50:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08e5b8e42482ea6f11711333306df76c8ff24d80
Cr-Commit-Position: refs/heads/master@{#436200}

Powered by Google App Engine
This is Rietveld 408576698