Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2544313002: Revert of image_decoder: Delay shutdown on idle (Closed)

Created:
4 years ago by Ken Rockot(use gerrit already)
Modified:
4 years ago
CC:
chromium-reviews, Theresa
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of image_decoder: Delay shutdown on idle (patchset #1 id:1 of https://codereview.chromium.org/2538833004/ ) Reason for revert: I did something stupid. Trivial UAF, will fix. Original issue's description: > image_decoder: Delay shutdown on idle > > Instead of immediately tearing down the image_decoder service > once it's idle, wait 5 seconds in case there are going to be > more requests soon. > > This mirrors the behavior of utility process image decoding > prior to servicification, and is intended to address latency > issues with multiple image decodes happening in quick (but not > quite immediate) succession. > > BUG=669835 > > Committed: https://crrev.com/0798a4585e6cb5df5e5596b8692656fca669cc28 > Cr-Commit-Position: refs/heads/master@{#435815} TBR=ben@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=669835 Committed: https://crrev.com/7438bbcf5741f228b5c4059ab266dee53fcace62 Cr-Commit-Position: refs/heads/master@{#435932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -21 lines) Patch
M services/image_decoder/image_decoder_service.h View 1 chunk +0 lines, -3 lines 0 comments Download
M services/image_decoder/image_decoder_service.cc View 3 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ken Rockot(use gerrit already)
Created Revert of image_decoder: Delay shutdown on idle
4 years ago (2016-12-02 14:03:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544313002/1
4 years ago (2016-12-02 14:04:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 14:05:20 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-02 14:10:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7438bbcf5741f228b5c4059ab266dee53fcace62
Cr-Commit-Position: refs/heads/master@{#435932}

Powered by Google App Engine
This is Rietveld 408576698