Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: net/tools/quic/quic_epoll_connection_helper_test.cc

Issue 25443002: Land Recent QUIC changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix to change SendAlarm crash Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/quic_connection_peer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_epoll_connection_helper_test.cc
diff --git a/net/tools/quic/quic_epoll_connection_helper_test.cc b/net/tools/quic/quic_epoll_connection_helper_test.cc
index a61813c9e4f4110473f66b7877c9057a377d3fd3..154c3936b699ee9407c3b3179960e46c0005b32c 100644
--- a/net/tools/quic/quic_epoll_connection_helper_test.cc
+++ b/net/tools/quic/quic_epoll_connection_helper_test.cc
@@ -30,7 +30,7 @@ namespace tools {
namespace test {
namespace {
-const char data1[] = "foo";
+const char kData[] = "foo";
const bool kFromPeer = true;
class TestConnectionHelper : public QuicEpollConnectionHelper {
@@ -81,7 +81,7 @@ class QuicEpollConnectionHelperTest : public ::testing::Test {
send_algorithm_(new testing::StrictMock<MockSendAlgorithm>),
helper_(new TestConnectionHelper(0, &epoll_server_)),
connection_(guid_, IPEndPoint(), helper_),
- frame1_(3, false, 0, data1) {
+ frame_(3, false, 0, kData) {
connection_.set_visitor(&visitor_);
connection_.SetSendAlgorithm(send_algorithm_);
epoll_server_.set_timeout_in_us(-1);
@@ -97,18 +97,18 @@ class QuicEpollConnectionHelperTest : public ::testing::Test {
QuicPacket* ConstructDataPacket(QuicPacketSequenceNumber number,
QuicFecGroupNumber fec_group) {
- header_.public_header.version_flag = false;
- header_.public_header.reset_flag = false;
- header_.fec_flag = false;
- header_.entropy_flag = false;
- header_.packet_sequence_number = number;
- header_.is_in_fec_group = fec_group == 0 ? NOT_IN_FEC_GROUP : IN_FEC_GROUP;
- header_.fec_group = fec_group;
+ QuicPacketHeader header;
+ header.public_header.version_flag = false;
+ header.public_header.reset_flag = false;
+ header.fec_flag = false;
+ header.entropy_flag = false;
+ header.packet_sequence_number = number;
+ header.is_in_fec_group = fec_group == 0 ? NOT_IN_FEC_GROUP : IN_FEC_GROUP;
+ header.fec_group = fec_group;
QuicFrames frames;
- QuicFrame frame(&frame1_);
- frames.push_back(frame);
- return framer_.BuildUnsizedDataPacket(header_, frames).packet;
+ frames.push_back(QuicFrame(&frame_));
+ return framer_.BuildUnsizedDataPacket(header, frames).packet;
}
QuicGuid guid_;
@@ -120,8 +120,7 @@ class QuicEpollConnectionHelperTest : public ::testing::Test {
TestConnection connection_;
testing::StrictMock<MockConnectionVisitor> visitor_;
- QuicPacketHeader header_;
- QuicStreamFrame frame1_;
+ QuicStreamFrame frame_;
};
TEST_F(QuicEpollConnectionHelperTest, DISABLED_TestRTORetransmission) {
« no previous file with comments | « net/quic/test_tools/quic_connection_peer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698