ios: Cleanup class/struct forward declarations

ios: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations using a homemade
script available in bug 662195 comments. An up-and-running presubmit
check is now available and should prevent new useless forward
declarations to come up.

BUG=662195
Committed: https://crrev.com/6f5774cd1b3e4d956437fd50762d5cdf3d0221ff
Cr-Commit-Position: refs/heads/master@{#435945}

[jbriance, 2016-12-02 12:14:00]

jbriance@cisco.com changed reviewers:
+ droger@chromium.org, noyau@chromium.org, rohitrao@chromium.org

[droger, 2016-12-02 14:14:10]

LGTM, thank you.

Can you add in the description that this CL was generated by the cleanFwdDecl.sh
script?

[droger, 2016-12-02 14:14:29]

The CQ bit was checked by droger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 14:14:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[droger, 2016-12-02 14:14:52]

I'm launching a CQ dry run for you.

[vabr (Chromium), 2016-12-02 14:17:44]

vabr@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2016-12-02 14:17:44]

ios/chrome/browser/passwords LGTM, thank you!
Vaclav

[jbriance, 2016-12-02 14:22:31]

Description was changed from

==========
ios: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in ios header files.

BUG=662195
==========

to

==========
ios: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations using a homemade
script available in bug 662195 comments. An up-and-running presubmit
check is now available and should prevent new useless forward
declarations to come up.

BUG=662195
==========

[jbriance, 2016-12-02 14:22:31]

jbriance@cisco.com changed reviewers:
- vabr@chromium.org

[pkl (ping after 24h if needed), 2016-12-02 14:23:04]

pkl@chromium.org changed reviewers:
+ eugenebut@chromium.org, pkl@chromium.org

[pkl (ping after 24h if needed), 2016-12-02 14:23:04]

+eugenebut for ios/web

[jbriance, 2016-12-02 14:23:27]

On 2016/12/02 14:14:10, droger wrote:
> Can you add in the description that this CL was generated by the
cleanFwdDecl.sh
> script?

Sure, done :)

[commit-bot: I haz the power, 2016-12-02 14:24:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 14:24:16]

Dry run: This issue passed the CQ dry run.

[noyau (Ping after 24h), 2016-12-02 14:24:23]

Thank you. lgtm.

[Eugene But (OOO till 7-30), 2016-12-02 15:51:34]

ios/web lgtm Thank you for doing this!

[jbriance, 2016-12-02 15:57:33]

The CQ bit was checked by jbriance@cisco.com

[commit-bot: I haz the power, 2016-12-02 15:58:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 16:03:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480694253477190, "parent_rev":
"f6dc3234b420cf91671593aed405feb541d2da7f", "commit_rev":
"9212a582e49512afd02b6e55dae4c8d57abfd845"}

[commit-bot: I haz the power, 2016-12-02 16:04:11]

Description was changed from

==========
ios: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations using a homemade
script available in bug 662195 comments. An up-and-running presubmit
check is now available and should prevent new useless forward
declarations to come up.

BUG=662195
==========

to

==========
ios: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations using a homemade
script available in bug 662195 comments. An up-and-running presubmit
check is now available and should prevent new useless forward
declarations to come up.

BUG=662195
==========

[commit-bot: I haz the power, 2016-12-02 16:04:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-02 16:06:03]

Description was changed from

==========
ios: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations using a homemade
script available in bug 662195 comments. An up-and-running presubmit
check is now available and should prevent new useless forward
declarations to come up.

BUG=662195
==========

to

==========
ios: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations using a homemade
script available in bug 662195 comments. An up-and-running presubmit
check is now available and should prevent new useless forward
declarations to come up.

BUG=662195

Committed: https://crrev.com/6f5774cd1b3e4d956437fd50762d5cdf3d0221ff
Cr-Commit-Position: refs/heads/master@{#435945}
==========

[commit-bot: I haz the power, 2016-12-02 16:06:05]

Patchset 1 (id:??) landed as
https://crrev.com/6f5774cd1b3e4d956437fd50762d5cdf3d0221ff
Cr-Commit-Position: refs/heads/master@{#435945}

[rohitrao (ping after 24h), 2016-12-02 18:35:42]

We seem to have some files that aren't actually compiled upstream, so this ended
up breaking the internal build.  Easy fix, but we should consider sending
cleanup CLs through the twosided trybots in the future.

Can I run this script over the internal repo as well?  Is it hard to run?