NavigationController: remove ReloadToRefreshContent

NavigationController: remove ReloadToRefreshContent

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

In this change, I do not remove actual caller code that existed
in Android port, because it was already removed accidentaly
in the following refactoring change.
https://codereview.chromium.org/2416723002

Because we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads fortunately, it didn't cause any regression,
and we can safely remove this interface now.

BUG=612080, 670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=miguelg@chromium.org

Committed: https://crrev.com/b887e7c4d46340e170ab47c12b3a0d75433250af
Cr-Commit-Position: refs/heads/master@{#436242}

[Takashi Toyoshima, 2016-12-02 09:42:41]

Description was changed from

==========
NavigationController: deprecated ReloadToRefreshContent

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

This was used by Android, but haven't been used accidentally
from https://codereview.chromium.org/2087543002.

Fortuantely, we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads, it didn't cause a regression.

BUG=612080, 670232
==========

to

==========
NavigationController: deprecated ReloadToRefreshContent

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

This was used by Android, but haven't been used accidentally
from https://codereview.chromium.org/2087543002.

Fortuantely, we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads, it didn't cause a regression.

BUG=612080, 670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Takashi Toyoshima, 2016-12-02 09:43:07]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[Takashi Toyoshima, 2016-12-02 09:43:28]

Description was changed from

==========
NavigationController: deprecated ReloadToRefreshContent

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

This was used by Android, but haven't been used accidentally
from https://codereview.chromium.org/2087543002.

Fortuantely, we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads, it didn't cause a regression.

BUG=612080, 670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
NavigationController: deprecated ReloadToRefreshContent

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

This was used by Android, but haven't been used accidentally
from https://codereview.chromium.org/2087543002.

Fortuantely, we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads, it didn't cause a regression.

BUG=612080, 670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Takashi Toyoshima, 2016-12-02 09:43:29]

toyoshim@chromium.org changed reviewers:
+ creis@chromium.org

[commit-bot: I haz the power, 2016-12-02 09:43:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2016-12-02 09:46:27]

toyoshim@chromium.org changed reviewers:
+ miguelg@chromium.org

[Takashi Toyoshima, 2016-12-02 09:48:30]

Description was changed from

==========
NavigationController: deprecated ReloadToRefreshContent

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

This was used by Android, but haven't been used accidentally
from https://codereview.chromium.org/2087543002.

Fortuantely, we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads, it didn't cause a regression.

BUG=612080, 670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
NavigationController: deprecated ReloadToRefreshContent

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

This was used by Android, but haven't been used accidentally
from https://codereview.chromium.org/2087543002.

Because we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads fortunately, it didn't cause any regression,
and we can safely deprecate this interface now.

BUG=612080, 670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Takashi Toyoshima, 2016-12-02 09:48:48]

Can you take a look?

[commit-bot: I haz the power, 2016-12-02 11:01:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 11:01:45]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2016-12-02 22:50:05]

Thanks for the cleanup!  LGTM.

Can you update the CL description, though?  I'm not sure what the "haven't been
used accidentally from" comment means.  Also s/deprecated/remove/.

[Takashi Toyoshima, 2016-12-05 05:48:30]

Description was changed from

==========
NavigationController: deprecated ReloadToRefreshContent

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

This was used by Android, but haven't been used accidentally
from https://codereview.chromium.org/2087543002.

Because we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads fortunately, it didn't cause any regression,
and we can safely deprecate this interface now.

BUG=612080, 670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
NavigationController: remove ReloadToRefreshContent

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

This was used by Android, but haven't been used accidentally
from https://codereview.chromium.org/2087543002.

Because we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads fortunately, it didn't cause any regression,
and we can safely deprecate this interface now.

BUG=612080, 670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Takashi Toyoshima, 2016-12-05 05:51:08]

Description was changed from

==========
NavigationController: remove ReloadToRefreshContent

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

This was used by Android, but haven't been used accidentally
from https://codereview.chromium.org/2087543002.

Because we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads fortunately, it didn't cause any regression,
and we can safely deprecate this interface now.

BUG=612080, 670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
NavigationController: remove ReloadToRefreshContent

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

In this change, I do not remove actual caller code that existed
in Android port, because it was already removed accidentaly
in the following refactoring change.
https://codereview.chromium.org/2087543002.

Because we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads fortunately, it didn't cause any regression,
and we can safely remove this interface now.

BUG=612080, 670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Takashi Toyoshima, 2016-12-05 05:55:58]

Description was changed from

==========
NavigationController: remove ReloadToRefreshContent

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

In this change, I do not remove actual caller code that existed
in Android port, because it was already removed accidentaly
in the following refactoring change.
https://codereview.chromium.org/2087543002.

Because we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads fortunately, it didn't cause any regression,
and we can safely remove this interface now.

BUG=612080, 670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
NavigationController: remove ReloadToRefreshContent

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

In this change, I do not remove actual caller code that existed
in Android port, because it was already removed accidentaly
in the following refactoring change.
https://codereview.chromium.org/2416723002

Because we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads fortunately, it didn't cause any regression,
and we can safely remove this interface now.

BUG=612080, 670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Takashi Toyoshima, 2016-12-05 05:56:36]

updated. Sorry, I referred a wrong CL in the description. I also change the URL.

[Takashi Toyoshima, 2016-12-05 05:59:48]

Description was changed from

==========
NavigationController: remove ReloadToRefreshContent

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

In this change, I do not remove actual caller code that existed
in Android port, because it was already removed accidentaly
in the following refactoring change.
https://codereview.chromium.org/2416723002

Because we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads fortunately, it didn't cause any regression,
and we can safely remove this interface now.

BUG=612080, 670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
NavigationController: remove ReloadToRefreshContent

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

In this change, I do not remove actual caller code that existed
in Android port, because it was already removed accidentaly
in the following refactoring change.
https://codereview.chromium.org/2416723002

Because we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads fortunately, it didn't cause any regression,
and we can safely remove this interface now.

BUG=612080, 670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=miguelg@chromium.org
==========

[Takashi Toyoshima, 2016-12-05 06:01:16]

I think Android side change can be TBR in this case.
Also, add Ted C to CC just in case. Ted C was a reviewer for the CL I mentioned
in the description.

[Takashi Toyoshima, 2016-12-05 06:01:23]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2016-12-05 06:01:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 07:53:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480917683001980, "parent_rev":
"6cd5feddd2553c0f59634e6173766e4a55c4af83", "commit_rev":
"4ecdb3d1b9ee20060f7f8936b39cab014df966ed"}

[commit-bot: I haz the power, 2016-12-05 07:53:56]

Description was changed from

==========
NavigationController: remove ReloadToRefreshContent

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

In this change, I do not remove actual caller code that existed
in Android port, because it was already removed accidentaly
in the following refactoring change.
https://codereview.chromium.org/2416723002

Because we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads fortunately, it didn't cause any regression,
and we can safely remove this interface now.

BUG=612080, 670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=miguelg@chromium.org
==========

to

==========
NavigationController: remove ReloadToRefreshContent

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

In this change, I do not remove actual caller code that existed
in Android port, because it was already removed accidentaly
in the following refactoring change.
https://codereview.chromium.org/2416723002

Because we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads fortunately, it didn't cause any regression,
and we can safely remove this interface now.

BUG=612080, 670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=miguelg@chromium.org
==========

[commit-bot: I haz the power, 2016-12-05 07:53:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-05 07:55:42]

Description was changed from

==========
NavigationController: remove ReloadToRefreshContent

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

In this change, I do not remove actual caller code that existed
in Android port, because it was already removed accidentaly
in the following refactoring change.
https://codereview.chromium.org/2416723002

Because we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads fortunately, it didn't cause any regression,
and we can safely remove this interface now.

BUG=612080, 670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=miguelg@chromium.org
==========

to

==========
NavigationController: remove ReloadToRefreshContent

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

In this change, I do not remove actual caller code that existed
in Android port, because it was already removed accidentaly
in the following refactoring change.
https://codereview.chromium.org/2416723002

Because we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads fortunately, it didn't cause any regression,
and we can safely remove this interface now.

BUG=612080, 670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=miguelg@chromium.org

Committed: https://crrev.com/b887e7c4d46340e170ab47c12b3a0d75433250af
Cr-Commit-Position: refs/heads/master@{#436242}
==========

[commit-bot: I haz the power, 2016-12-05 07:55:43]

Patchset 1 (id:??) landed as
https://crrev.com/b887e7c4d46340e170ab47c12b3a0d75433250af
Cr-Commit-Position: refs/heads/master@{#436242}