[wasm] Fix WasmInstanceWrapper allocation.

[wasm] Fix WasmInstanceWrapper allocation.

In the current implementation, WasmInstanceWrapper is allocated after the imports for the instance are processed, and before the InstanceFinalizer callback is associated with the instance. This raises the possibility of triggering a gc in the middle of the instantiate flow which is incorrect.

BUG=5707
R=titzer@chromium.org, petermarshall@chromium.org

Committed: https://crrev.com/6454102c5b68caa13411ca0d07e915444fd90eec
Cr-Commit-Position: refs/heads/master@{#41464}

[gdeepti, 2016-12-02 09:22:43]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 09:22:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 09:50:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 09:50:37]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-12-02 09:54:21]

On 2016/12/02 09:22:54, gdeepti wrote:

lgtm. Is it possible to write a test that is more likely to trigger the bug,
like test/mjsunit/wasm/gc-stress.js ?

[gdeepti, 2016-12-03 00:00:13]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-03 00:00:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2016-12-03 00:29:35]

On 2016/12/02 09:54:21, titzer wrote:
> On 2016/12/02 09:22:54, gdeepti wrote:
> 
> lgtm. Is it possible to write a test that is more likely to trigger the bug,
> like test/mjsunit/wasm/gc-stress.js ?

Added test instance-memory-gc-stress.js, allocates larger chunks of memory,
interspersed calls to the gc after each instantiate/grow.

[gdeepti, 2016-12-03 00:29:41]

The CQ bit was checked by gdeepti@chromium.org

[gdeepti, 2016-12-03 00:29:42]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2544273002/#ps40001
(title: "rename test")

[commit-bot: I haz the power, 2016-12-03 00:29:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 01:29:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480724981939740,
"parent_rev": "2be78e584652f5fae7256b891e036cc116eed50c", "commit_rev":
"410a9ebfb18c6fef61f2efb63f6a1e69cdbd9ce6"}

[commit-bot: I haz the power, 2016-12-03 01:29:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-03 01:29:55]

Description was changed from

==========
[wasm] Fix WasmInstanceWrapper allocation.

In the current implementation, WasmInstanceWrapper is allocated after the
imports for the instance are processed, and before the InstanceFinalizer
callback is associated with the instance. This raises the possibility of
triggering a gc in the middle of the instantiate flow which is incorrect.

BUG=5707

R=titzer@chromium.org, petermarshall@chromium.org
==========

to

==========
[wasm] Fix WasmInstanceWrapper allocation.

In the current implementation, WasmInstanceWrapper is allocated after the
imports for the instance are processed, and before the InstanceFinalizer
callback is associated with the instance. This raises the possibility of
triggering a gc in the middle of the instantiate flow which is incorrect.

BUG=5707

R=titzer@chromium.org, petermarshall@chromium.org

Committed: https://crrev.com/6454102c5b68caa13411ca0d07e915444fd90eec
Cr-Commit-Position: refs/heads/master@{#41464}
==========

[commit-bot: I haz the power, 2016-12-03 01:29:56]

Patchset 3 (id:??) landed as
https://crrev.com/6454102c5b68caa13411ca0d07e915444fd90eec
Cr-Commit-Position: refs/heads/master@{#41464}