Disable save-to-file button until there is some text

Disable save-to-file button until there is some text

Due to the change caused by
https://www.chromestatus.com/features/5683408571203584,
we do not update layout in the background while alert modal dialog is
showing up.

This has caused a regression in chrome://net-internals/#export ,
where we show red border before calling alert() to draw user's attention.

We could also use window.setTimeout() to avoid the issue, but disabling
save-to-file button is probably a better UX.

BUG=668031
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3aeac6ac2bb076ec6d08dd1056f8b41a981b3771
Cr-Commit-Position: refs/heads/master@{#436780}

[Changwan Ryu, 2016-12-02 07:07:05]

Description was changed from

==========
Disable save-to-file button until there is some text

Due to the change caused by
https://www.chromestatus.com/features/5683408571203584,
we do not update layout in the background while alert modal dialog is
showing up.

This has caused a regression in chrome://net-internals/#export ,
where we show red border before calling alert() to draw user's attention.

We could also use window.setTimeout() to avoid the issue, but disabling
save-to-file button is probably a better UX.

BUG=668031
==========

to

==========
Disable save-to-file button until there is some text

Due to the change caused by
https://www.chromestatus.com/features/5683408571203584,
we do not update layout in the background while alert modal dialog is
showing up.

This has caused a regression in chrome://net-internals/#export ,
where we show red border before calling alert() to draw user's attention.

We could also use window.setTimeout() to avoid the issue, but disabling
save-to-file button is probably a better UX.

BUG=668031
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Changwan Ryu, 2016-12-02 07:10:25]

changwan@chromium.org changed reviewers:
+ mmenke@chromium.org

[Changwan Ryu, 2016-12-02 07:10:26]

PTAL

[Changwan Ryu, 2016-12-06 06:54:53]

On 2016/12/02 07:10:26, Changwan Ryu wrote:
> PTAL

ping?

[mmenke, 2016-12-06 15:42:27]

On 2016/12/06 06:54:53, Changwan Ryu wrote:
> On 2016/12/02 07:10:26, Changwan Ryu wrote:
> > PTAL
> 
> ping?

Sorry for the delay, missed this one.

LGTM!

[Changwan Ryu, 2016-12-06 21:54:07]

The CQ bit was checked by changwan@chromium.org

[commit-bot: I haz the power, 2016-12-06 21:54:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 00:34:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481061247333180, "parent_rev":
"231be4e7a6628af800970e0c194195d5bc551068", "commit_rev":
"6d96d66eef7b82e57774c812231d6be260fc34d5"}

[commit-bot: I haz the power, 2016-12-07 00:34:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-07 00:37:23]

Description was changed from

==========
Disable save-to-file button until there is some text

Due to the change caused by
https://www.chromestatus.com/features/5683408571203584,
we do not update layout in the background while alert modal dialog is
showing up.

This has caused a regression in chrome://net-internals/#export ,
where we show red border before calling alert() to draw user's attention.

We could also use window.setTimeout() to avoid the issue, but disabling
save-to-file button is probably a better UX.

BUG=668031
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Disable save-to-file button until there is some text

Due to the change caused by
https://www.chromestatus.com/features/5683408571203584,
we do not update layout in the background while alert modal dialog is
showing up.

This has caused a regression in chrome://net-internals/#export ,
where we show red border before calling alert() to draw user's attention.

We could also use window.setTimeout() to avoid the issue, but disabling
save-to-file button is probably a better UX.

BUG=668031
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3aeac6ac2bb076ec6d08dd1056f8b41a981b3771
Cr-Commit-Position: refs/heads/master@{#436780}
==========

[commit-bot: I haz the power, 2016-12-07 00:37:24]

Patchset 1 (id:??) landed as
https://crrev.com/3aeac6ac2bb076ec6d08dd1056f8b41a981b3771
Cr-Commit-Position: refs/heads/master@{#436780}