Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 254423003: base: Test the cost of adding observers on message loops. (Closed)

Created:
6 years, 8 months ago by epenner
Modified:
6 years, 8 months ago
Reviewers:
epennerAtGoogle, Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

base: Test the cost of adding observers on message loops. Adds about ~5us per task on Nexus 4. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266155

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M base/threading/thread_perftest.cc View 1 chunk +26 lines, -0 lines 2 comments Download

Messages

Total messages: 14 (0 generated)
epenner
Ptal. Not as big of a difference as I thought, but it's good to know ...
6 years, 8 months ago (2014-04-24 02:01:20 UTC) #1
Nico
lgtm https://codereview.chromium.org/254423003/diff/20001/base/threading/thread_perftest.cc File base/threading/thread_perftest.cc (right): https://codereview.chromium.org/254423003/diff/20001/base/threading/thread_perftest.cc#newcode156 base/threading/thread_perftest.cc:156: MessageLoopObserver message_loop_observer; Does this have to be a ...
6 years, 8 months ago (2014-04-24 02:52:19 UTC) #2
epenner
https://codereview.chromium.org/254423003/diff/20001/base/threading/thread_perftest.cc File base/threading/thread_perftest.cc (right): https://codereview.chromium.org/254423003/diff/20001/base/threading/thread_perftest.cc#newcode156 base/threading/thread_perftest.cc:156: MessageLoopObserver message_loop_observer; On 2014/04/24 02:52:20, Nico wrote: > Does ...
6 years, 8 months ago (2014-04-24 03:14:35 UTC) #3
epenner
The CQ bit was checked by epenner@chromium.org
6 years, 8 months ago (2014-04-24 03:14:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/254423003/20001
6 years, 8 months ago (2014-04-24 03:15:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 03:48:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-24 03:48:28 UTC) #7
epenner
The CQ bit was checked by epenner@chromium.org
6 years, 8 months ago (2014-04-24 18:58:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/254423003/20001
6 years, 8 months ago (2014-04-24 21:08:57 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 22:58:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-24 22:58:55 UTC) #11
epennerAtGoogle
The CQ bit was checked by epenner@google.com
6 years, 8 months ago (2014-04-25 02:41:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/254423003/20001
6 years, 8 months ago (2014-04-25 02:45:55 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 08:28:26 UTC) #14
Message was sent while issue was closed.
Change committed as 266155

Powered by Google App Engine
This is Rietveld 408576698