Fix the position of context menu for BrowserPlugins inside OOPIF

content/browser/web_contents/web_contents_view_guest.cc

Index: content/browser/web_contents/web_contents_view_guest.cc
diff --git a/content/browser/web_contents/web_contents_view_guest.cc b/content/browser/web_contents/web_contents_view_guest.cc
index b2b86fa755e42097b0fedadd693a32b281cd57be..a93bc375bbbdc45d817dd74f21b5396cff509509 100644
--- a/content/browser/web_contents/web_contents_view_guest.cc
+++ b/content/browser/web_contents/web_contents_view_guest.cc
@@ -92,7 +92,8 @@ void WebContentsViewGuest::GetContainerBounds(gfx::Rect* out) const {
   if (guest_->embedder_web_contents()) {
     // We need embedder container's bounds to calculate our bounds.
     guest_->embedder_web_contents()->GetView()->GetContainerBounds(out);
-    gfx::Point guest_coordinates = guest_->GetScreenCoordinates(gfx::Point());

[lfg, 2016/12/06 00:23:53]

Will other uses of GetScreenCoordinates have the same problem? Should we change
GetScreenCoordinates instead?

[EhsanK, 2016/12/06 01:00:12]

GetScreenCoordinates() and the new method added have two different
functionalities now. Screen coordinate is with respect to embedder, and the new
method with respect to embedder WebContents (root view I suppose). So it
shouldn't be like one would necessarily replace the other.

As for other applications of it, I guess they seem correct. I noticed the
following usages:
1- GetViewBounds() in RWHVG. This is correct as we convert the owner view bounds
along the |guest_window_rect_| offset.

2- DnD:  It seems incorrect to use GetScreenCoordinates() when the embedder is
an OOPIF, but I would not change it for two reasons:
  2-a There is a TODO(paulmeyer) about sending the ClientXY to
BrowserPluginEmbedder().
  2-b We don't actually support drag and drop for PDF right now (it looks
broken).

3- IME usages. It is correct since we deal with owner RWHV. But IME window
position is broken on PDF anyway (I guess selection bounds and range are not
transformed/reported properly).

So I guess for now we should keep the usages of GetScreenCoordinates() as is.

[lfg, 2016/12/06 01:22:25]

Acknowledged.

+    gfx::Point guest_coordinates =
+        guest_->GetCoordinatesInEmbedderWebContents(gfx::Point());
     out->Offset(guest_coordinates.x(), guest_coordinates.y());
   } else {
     out->set_origin(gfx::Point());