Fix the position of context menu for BrowserPlugins inside OOPIF

content/browser/browser_plugin/browser_plugin_guest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 
@@ skipping 345 matching lines @@
   auto* render_widget_host = RenderWidgetHostImpl::From(
       GetWebContents()->GetRenderViewHost()->GetWidget());
   render_widget_host->NotifyScreenInfoChanged();
 
   // TODO(chrishtr): this code is wrong. The navigate_on_drag_drop field will
   // be reset again the next time preferences are updated.
   WebPreferences prefs =
       GetWebContents()->GetRenderViewHost()->GetWebkitPreferences();
   prefs.navigate_on_drag_drop = false;
   GetWebContents()->GetRenderViewHost()->UpdateWebkitPreferences(prefs);
+
+  if (auto* owner_rwhv = GetOwnerRenderWidgetHostView()) {
+    guest_window_rect_.set_origin(owner_rwhv->TransformPointToRootCoordSpace(
+        guest_window_rect_.origin()));
+  }
 }
 
 BrowserPluginGuest::~BrowserPluginGuest() {
 }
 
 // static
 BrowserPluginGuest* BrowserPluginGuest::Create(
     WebContentsImpl* web_contents,
     BrowserPluginGuestDelegate* delegate) {
   return new BrowserPluginGuest(
@@ skipping 83 matching lines @@
 
 void BrowserPluginGuest::ResendEventToEmbedder(
     const blink::WebInputEvent& event) {
   if (!attached() || !owner_web_contents_)
     return;
 
   DCHECK(browser_plugin_instance_id_);
   RenderWidgetHostViewBase* view =
       static_cast<RenderWidgetHostViewBase*>(GetOwnerRenderWidgetHostView());
 
   gfx::Vector2d offset_from_embedder = guest_window_rect_.OffsetFromOrigin();

[lfg, 2016/12/05 19:44:18]

If we are transforming guest_window_rect to the root coordinates, then this
isn't an offset_from_embedder anymore.

Also, does this means that we were sending all events with wrong coordinates to
the guests?

Does this work with BrowserPlugins embedding other BrowserPlugins? For example,
<appview>?

[EhsanK, 2016/12/06 00:08:54]

Correct.
No since the conversion and transforms happen in BrowserPlugin on the renderer
side. But, but here the Resending coordinates would be incorrect. Thanks for
pointing out. In the patch I am not transforming the
guest window but rather change the way container bounds are calculated in
WebContentsViewGuest.

Also, both RWHVG and RWHV for tab return point when we do the transform. Since
no other guests can be in OOPIF this new code path will only affect
MimeHandlerView.

A non-OOPIF <appview> cannot be in any OOPIF. An OOPIF-<appview> might be in
OOPIF but we would not hit the modified code path.

   if (event.type == blink::WebInputEvent::GestureScrollUpdate) {
     blink::WebGestureEvent resent_gesture_event;
     memcpy(&resent_gesture_event, &event, sizeof(blink::WebGestureEvent));
     resent_gesture_event.x += offset_from_embedder.x();
     resent_gesture_event.y += offset_from_embedder.y();
     // Mark the resend source with the browser plugin's instance id, so the
     // correct browser_plugin will know to ignore the event.
     resent_gesture_event.resendingPluginId = browser_plugin_instance_id_;
     ui::LatencyInfo latency_info =
         ui::WebInputEventTraits::CreateLatencyInfoForWebGestureEvent(
@@ skipping 515 matching lines @@
   if (mouse_locked_)
     Send(new ViewMsg_MouseLockLost(routing_id()));
   mouse_locked_ = false;
 }
 
 void BrowserPluginGuest::OnUpdateGeometry(int browser_plugin_instance_id,
                                           const gfx::Rect& view_rect) {
   // The plugin has moved within the embedder without resizing or the
   // embedder/container's view rect changing.
   guest_window_rect_ = view_rect;
+  if (auto* rwhv = GetOwnerRenderWidgetHostView()) {
+    guest_window_rect_.set_origin(
+        rwhv->TransformPointToRootCoordSpace(guest_window_rect_.origin()));
+  }
+
   GetWebContents()->SendScreenRects();
 }
 
 void BrowserPluginGuest::OnHasTouchEventHandlers(bool accept) {
   SendMessageToEmbedder(
       base::MakeUnique<BrowserPluginMsg_ShouldAcceptTouchEvents>(
           browser_plugin_instance_id(), accept));
 }
 
 #if defined(OS_MACOSX)
@@ skipping 48 matching lines @@
           range, character_bounds);
 }
 #endif
 
 void BrowserPluginGuest::SetContextMenuPosition(const gfx::Point& position) {
   if (delegate_)
     delegate_->SetContextMenuPosition(position);
 }
 
 }  // namespace content