Display images in multiline Braille

chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js

Index: chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js
diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js b/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js
index 523c3e7aa754308b8540bd42afca742b0ec6403a..4ae0143d5887f994f01b25420bb0219b4a406263 100644
--- a/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js
+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js
@@ -52,10 +52,13 @@ cvox.OptionsPage.init = function() {
     $('brailleWordWrap').checked = items.brailleWordWrap;
   });
 
-  $('virtual_braille_display_rows_input').value =
-      localStorage['virtualBrailleRows'];
-  $('virtual_braille_display_columns_input').value =
-      localStorage['virtualBrailleColumns'];
+  chrome.storage.local.get({'virtualBrailleRows' : 1}, function(items) {

[dmazzoni, 2016/12/05 17:29:41]

Same - put this in a separate change

[ultimatedbz, 2016/12/05 19:37:38]

Done.

+    $('virtual_braille_display_rows_input').value = items['virtualBrailleRows'];
+  });
+  chrome.storage.local.get({'virtualBrailleColumns' : 40}, function(items) {
+    $('virtual_braille_display_columns_input').value =
+        items['virtualBrailleColumns'];
+  });
   var changeToInterleave =
       Msgs.getMsg('options_change_current_display_style_interleave');
   var changeToSideBySide =
@@ -94,8 +97,9 @@ cvox.OptionsPage.init = function() {
 
   var clearVirtualDisplay = function() {
     var groups = [];
-    var sizeOfDisplay = parseInt(localStorage['virtualBrailleRows'], 10) *
-        parseInt(localStorage['virtualBrailleColumns'], 10);
+    var sizeOfDisplay =
+        parseInt($('virtual_braille_display_rows_input').innerHTML, 10) *
+        parseInt($('virtual_braille_display_columns_input').innerHTML, 10);
     for (var i = 0; i < sizeOfDisplay; i++) {
         groups.push(['X', 'X']);
     }
@@ -144,17 +148,25 @@ cvox.OptionsPage.update = function() {
  */
 var handleNumericalInputPref = function(id, pref) {
   $(id).addEventListener('input', function(evt) {
-    if ($(id).value === '')
+    if ($(id).value === '') {
       return;
-    else if (parseInt($(id).value, 10) < 1 || parseInt($(id).value, 10) > 99)
-      $(id).value = localStorage[pref];
-    else
-      localStorage[pref] = $(id).value;
+    }
+    else if (parseInt($(id).value, 10) < 1 || parseInt($(id).value, 10) > 99) {
+      chrome.storage.local.get(pref, function(items) {
+        $(id).value = items[pref];
+      });
+    }else {
+      var items = {};
+      items[pref] = $(id).value;
+      chrome.storage.local.set(items);
+    }
   }, true);
 
   $(id).addEventListener('focusout', function(evt) {
     if ($(id).value === '')
-      $(id).value = localStorage[pref];
+      chrome.storage.local.get(pref, function(items) {
+        $(id).value = items[pref];
+      });
   }, true);
 };