third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py - Issue 2544173002: Skip commits that don't generate a patch + fixes to get export working

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py

Issue 2544173002: Skip commits that don't generate a patch + fixes to get export working (Closed)

Patch Set: Refactor TestExporter, clean up other parts Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/w3c/sync_wpt.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py

index 20085219ae4b88f4e9e6494f9a960e253fa2a6ee..80bc6d7d65cc23ac26bcbbdbb69775013d4a317a 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py

@@ -84,6 +84,6 @@ class LocalWPTTest(unittest.TestCase):

local_wpt = LocalWPT(host)

local_branch_name = local_wpt.create_branch_with_patch('message', 'patch')

- self.assertEqual(len(host.executive.calls), 9)

+ self.assertEqual(len(host.executive.calls), 11)

self.assertEqual(local_branch_name, 'chromium-export-try')

# TODO(jeffcarp): Add more specific assertions