Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 2544163002: Fix runtime strong mode error in ListMixin (Closed)

Created:
4 years ago by vsm
Modified:
4 years ago
Reviewers:
Jacob
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -41 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 6 chunks +9 lines, -8 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 6 chunks +9 lines, -8 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 6 chunks +9 lines, -8 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 6 chunks +9 lines, -8 lines 0 comments Download
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 1 chunk +3 lines, -0 lines 0 comments Download
A pkg/dev_compiler/test/codegen/lib/collection/list_test.dart View 1 chunk +40 lines, -0 lines 1 comment Download
M pkg/dev_compiler/test/codegen_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/lib/collection/list.dart View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
vsm
https://codereview.chromium.org/2544163002/diff/1/pkg/dev_compiler/test/codegen/lib/collection/list_test.dart File pkg/dev_compiler/test/codegen/lib/collection/list_test.dart (right): https://codereview.chromium.org/2544163002/diff/1/pkg/dev_compiler/test/codegen/lib/collection/list_test.dart#newcode32 pkg/dev_compiler/test/codegen/lib/collection/list_test.dart:32: list = new MyList<int>([1, 2, 3]); FYI: The strong ...
4 years ago (2016-12-01 23:33:54 UTC) #2
Jacob
lgtm
4 years ago (2016-12-01 23:34:58 UTC) #3
vsm
4 years ago (2016-12-01 23:41:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
201c5b9297e5b701d4ee03ac42e6325629baf73c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698