Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2544123004: [fullcodegen] Remove super property access support. (Closed)

Created:
4 years ago by Michael Starzinger
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Remove super property access support. This removes support for accessing super properties (load, store & call) from the {FullCodeGenerator}. Consequently optimized code containing such constructs must use the {BytecodeGraphBuilder} and can no longer use the {AstGraphBuilder} for graph building. R=bmeurer@chromium.org BUG=v8:5657 Committed: https://crrev.com/a97258b00c17f7596e8021b7954208e860272444 Cr-Commit-Position: refs/heads/master@{#41478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -2462 lines) Patch
M src/compiler/ast-graph-builder.h View 2 chunks +0 lines, -11 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 11 chunks +22 lines, -226 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 15 chunks +26 lines, -250 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 15 chunks +26 lines, -249 lines 0 comments Download
M src/full-codegen/full-codegen.h View 3 chunks +0 lines, -18 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 5 chunks +12 lines, -46 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 16 chunks +26 lines, -233 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 15 chunks +26 lines, -241 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 15 chunks +26 lines, -241 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 15 chunks +26 lines, -241 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 15 chunks +26 lines, -237 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 15 chunks +26 lines, -236 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 16 chunks +26 lines, -233 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael Starzinger
4 years ago (2016-12-02 14:28:03 UTC) #3
Benedikt Meurer
Awesome! LGTM.
4 years ago (2016-12-05 09:40:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544123004/1
4 years ago (2016-12-05 09:45:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 10:11:29 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-05 10:11:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a97258b00c17f7596e8021b7954208e860272444
Cr-Commit-Position: refs/heads/master@{#41478}

Powered by Google App Engine
This is Rietveld 408576698