Added MojoCompositorFrameSink::EvictFrame() and MojoCompositorFrameSinkClient::WillDrawSurface()

Added MojoCompositorFrameSink::EvictFrame() and MojoCompositorFrameSinkClient::WillDrawSurface()

This is a first step to separate exo::SurfaceFactoryOwner into
exo::CompositorFrameSink and exo::CompositorFrameSinkHolder
(WIP CL: https://codereview.chromium.org/2493223002)

BUG=659601
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/7fe38563b35eee5ee8818232d1ad15530ab53fa7
Cr-Commit-Position: refs/heads/master@{#436117}

[Alex Z., 2016-12-01 21:39:12]

Description was changed from

==========
Added MojoCompositorFrameSink::EvictFrame() and
MojoCompositorFrameSinkClient::WillDrawSurface()

This is a first step to separate exo::SurfaceFactoryOwner into
exo::CompositorFrameSink and exo::CompositorFrameSinkHolder
(WIP CL: https://codereview.chromium.org/2493223002)

BUG=659601
==========

to

==========
Added MojoCompositorFrameSink::EvictFrame() and
MojoCompositorFrameSinkClient::WillDrawSurface()

This is a first step to separate exo::SurfaceFactoryOwner into
exo::CompositorFrameSink and exo::CompositorFrameSinkHolder
(WIP CL: https://codereview.chromium.org/2493223002)

BUG=659601
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Alex Z., 2016-12-01 21:39:19]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 21:39:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alex Z., 2016-12-01 21:53:26]

staraz@chromium.org changed reviewers:
+ pdr@chromium.org, sky@chromium.org, tsepez@chromium.org, xlai@chromium.org

[Alex Z., 2016-12-01 21:53:26]

pdr@chromium.org: Please review changes in third_party/WebKit

xlai@chromium.org: Please review changes in content/browser/renderer_host

sky@chromium.org: Please review changes in services/ui and ui/aura/mus

tsepez@: Please review changes in cc/ipc/mojo_compositor_frame_sink.mojom

[Fady Samuel, 2016-12-01 21:55:40]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2016-12-01 21:55:41]

LGTM + one comment.

https://codereview.chromium.org/2544103002/diff/1/services/ui/surfaces/gpu_co...
File services/ui/surfaces/gpu_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2544103002/diff/1/services/ui/surfaces/gpu_co...
services/ui/surfaces/gpu_compositor_frame_sink.cc:102: NOTIMPLEMENTED();
Implement it here? surface_factory_.EvictSurface();

[Fady Samuel, 2016-12-01 21:56:24]

fsamuel@chromium.org changed reviewers:
+ danakj@chromium.org

[Fady Samuel, 2016-12-01 21:56:24]

+danakj@

[Alex Z., 2016-12-01 21:59:01]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 21:59:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alex Z., 2016-12-01 21:59:15]

https://codereview.chromium.org/2544103002/diff/1/services/ui/surfaces/gpu_co...
File services/ui/surfaces/gpu_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2544103002/diff/1/services/ui/surfaces/gpu_co...
services/ui/surfaces/gpu_compositor_frame_sink.cc:102: NOTIMPLEMENTED();
On 2016/12/01 21:55:41, Fady Samuel wrote:
> Implement it here? surface_factory_.EvictSurface();

Done.

[pdr., 2016-12-01 21:59:54]

On 2016/12/01 at 21:56:24, fsamuel wrote:
> +danakj@

WebKit LGTM

[Tom Sepez, 2016-12-01 22:06:45]

mojom LGTM

[sky, 2016-12-01 22:54:57]

LGTM

[commit-bot: I haz the power, 2016-12-01 23:33:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 23:33:59]

Dry run: This issue passed the CQ dry run.

[danakj, 2016-12-02 00:01:14]

https://codereview.chromium.org/2544103002/diff/20001/cc/ipc/mojo_compositor_...
File cc/ipc/mojo_compositor_frame_sink.mojom (right):

https://codereview.chromium.org/2544103002/diff/20001/cc/ipc/mojo_compositor_...
cc/ipc/mojo_compositor_frame_sink.mojom:58: WillDrawSurface();
no damage rect or local frame id?

[Alex Z., 2016-12-02 16:17:15]

https://codereview.chromium.org/2544103002/diff/20001/cc/ipc/mojo_compositor_...
File cc/ipc/mojo_compositor_frame_sink.mojom (right):

https://codereview.chromium.org/2544103002/diff/20001/cc/ipc/mojo_compositor_...
cc/ipc/mojo_compositor_frame_sink.mojom:58: WillDrawSurface();
On 2016/12/02 00:01:14, danakj wrote:
> no damage rect or local frame id?

This was first added in https://codereview.chromium.org/2493223002/ for
exo::Surface.
Local frame ID was not needed because exo::Surface manages its own damage rect
and local frame ID. 
exo::Surface doesn't need a damage rect for its own WillDraw().

MojoCompositorFrameSink::SubmitCompositorFrame() now takes a LocalFrameId so I
think it should be fine.

[Alex Z., 2016-12-02 16:26:04]

staraz@chromium.org changed reviewers:
+ xidachen@chromium.org
- xlai@chromium.org

[Alex Z., 2016-12-02 16:26:05]

xidachen@: Please review changes in content/browser/renderer_host/

[xidachen, 2016-12-02 16:30:02]

On 2016/12/02 16:26:05, StarAZ1 wrote:
> xidachen@: Please review changes in content/browser/renderer_host/

lgtm

[danakj, 2016-12-02 21:02:06]

On 2016/12/02 16:17:15, StarAZ1 wrote:
>
https://codereview.chromium.org/2544103002/diff/20001/cc/ipc/mojo_compositor_...
> File cc/ipc/mojo_compositor_frame_sink.mojom (right):
> 
>
https://codereview.chromium.org/2544103002/diff/20001/cc/ipc/mojo_compositor_...
> cc/ipc/mojo_compositor_frame_sink.mojom:58: WillDrawSurface();
> On 2016/12/02 00:01:14, danakj wrote:
> > no damage rect or local frame id?
> 
> This was first added in https://codereview.chromium.org/2493223002/ for
> exo::Surface.
> Local frame ID was not needed because exo::Surface manages its own damage rect
> and local frame ID. 
> exo::Surface doesn't need a damage rect for its own WillDraw().
> 
> MojoCompositorFrameSink::SubmitCompositorFrame() now takes a LocalFrameId so I
> think it should be fine.

ok, cc/ LGTM. I figure other things will need it as we decouple UI and display
compositor but I guess we can add them then.

[Alex Z., 2016-12-02 22:18:15]

The CQ bit was checked by staraz@chromium.org

[Alex Z., 2016-12-02 22:18:16]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2544103002/#ps20001
(title: "Addressed a comment")

[commit-bot: I haz the power, 2016-12-02 22:19:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 01:16:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480717095281930,
"parent_rev": "9eca2ad6c58b3a57fcf61e1cafddabbbd6d4713a", "commit_rev":
"f4f8203b4898a89e347f22153fa447ce47d1a1db"}

[commit-bot: I haz the power, 2016-12-03 01:17:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-03 01:20:57]

Description was changed from

==========
Added MojoCompositorFrameSink::EvictFrame() and
MojoCompositorFrameSinkClient::WillDrawSurface()

This is a first step to separate exo::SurfaceFactoryOwner into
exo::CompositorFrameSink and exo::CompositorFrameSinkHolder
(WIP CL: https://codereview.chromium.org/2493223002)

BUG=659601
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Added MojoCompositorFrameSink::EvictFrame() and
MojoCompositorFrameSinkClient::WillDrawSurface()

This is a first step to separate exo::SurfaceFactoryOwner into
exo::CompositorFrameSink and exo::CompositorFrameSinkHolder
(WIP CL: https://codereview.chromium.org/2493223002)

BUG=659601
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/7fe38563b35eee5ee8818232d1ad15530ab53fa7
Cr-Commit-Position: refs/heads/master@{#436117}
==========

[commit-bot: I haz the power, 2016-12-03 01:20:58]

Patchset 2 (id:??) landed as
https://crrev.com/7fe38563b35eee5ee8818232d1ad15530ab53fa7
Cr-Commit-Position: refs/heads/master@{#436117}

[kylechar, 2016-12-05 15:18:30]

kylechar@chromium.org changed reviewers:
+ kylechar@chromium.org

[kylechar, 2016-12-05 15:18:31]

https://codereview.chromium.org/2544103002/diff/20001/services/ui/ws/frame_ge...
File services/ui/ws/frame_generator.cc (right):

https://codereview.chromium.org/2544103002/diff/20001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:130: NOTIMPLEMENTED();
This is causing lots of console spam. I think it gets called 60 times a second?

https://codereview.chromium.org/2544103002/diff/20001/ui/aura/mus/window_comp...
File ui/aura/mus/window_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2544103002/diff/20001/ui/aura/mus/window_comp...
ui/aura/mus/window_compositor_frame_sink.cc:116: NOTIMPLEMENTED();
Same problem here.