Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2544063003: Revert of cc: Remove map lookup from RenderSurfaceImpl::EffectTreeIndex (Closed)

Created:
4 years ago by ajuma
Modified:
4 years ago
Reviewers:
jaydasika, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Remove map lookup from RenderSurfaceImpl::EffectTreeIndex (patchset #1 id:1 of https://codereview.chromium.org/2540333002/ ) Reason for revert: This is causing crashes: http://crbug.com/670679 Original issue's description: > cc: Remove map lookup from RenderSurfaceImpl::EffectTreeIndex > > The map lookup was added by http://crrev.com/434349, but caused a > 5-10% regression in CalcDrawPropsTests cc_perftests. This CL sets > the effect tree index on the surface during the surface update step > (when EffectNode::render_surface gets updated). > > BUG=670074 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Committed: https://crrev.com/2d1272d61ee51ba2e2171c77c3cc4545cd288d99 > Cr-Commit-Position: refs/heads/master@{#435672} TBR=weiliangc@chromium.org,jaydasika@chromium.org BUG=670074, 670679 Committed: https://crrev.com/9d01b1b4fb103fb74319a072cc8591dc3e196685 Cr-Commit-Position: refs/heads/master@{#435951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -23 lines) Patch
M cc/layers/render_surface_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/layers/render_surface_impl.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M cc/layers/render_surface_unittest.cc View 1 chunk +4 lines, -11 lines 0 comments Download
M cc/trees/draw_property_utils.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
ajuma
Created Revert of cc: Remove map lookup from RenderSurfaceImpl::EffectTreeIndex
4 years ago (2016-12-02 15:41:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544063003/1
4 years ago (2016-12-02 15:43:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 16:40:20 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-02 16:43:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d01b1b4fb103fb74319a072cc8591dc3e196685
Cr-Commit-Position: refs/heads/master@{#435951}

Powered by Google App Engine
This is Rietveld 408576698