Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2544053002:
v8: Remove dependency on xdisplaycheck (Closed)
|
Created:
4 years ago by Tom (Use chromium acct) Modified:
4 years ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Descriptionv8: Remove dependency on xdisplaycheck
BUG=670470
R=dpranke@chromium.org
Committed: https://crrev.com/ed48cdbc6a36faf91f7f6c72ee3536a9d1eb1c68
Cr-Commit-Position: refs/heads/master@{#41460}
Patch Set 1 #
Messages
Total messages: 18 (12 generated)
Description was changed from ========== Remove dependency on xdisplaycheck ========== to ========== v8: Remove dependency on xdisplaycheck R=dpranke@chromium.org ==========
thomasanderson@google.com changed reviewers: + dpranke@chromium.org
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dpranke@chromium.org changed reviewers: + machenbach@chromium.org
lgtm. To machenbach@ for actual review and approval.
Description was changed from ========== v8: Remove dependency on xdisplaycheck R=dpranke@chromium.org ========== to ========== v8: Remove dependency on xdisplaycheck BUG=670470 R=dpranke@chromium.org ==========
lgtm - this part is dead code in v8 anyways...
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480697539760940, "parent_rev":
"7729d3cf1a836b0dce3ec143c6f94e4abc423dd1", "commit_rev":
"baea5f493d0e79c3b872a9196f1bca993fb98528"}
Message was sent while issue was closed.
Description was changed from ========== v8: Remove dependency on xdisplaycheck BUG=670470 R=dpranke@chromium.org ========== to ========== v8: Remove dependency on xdisplaycheck BUG=670470 R=dpranke@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== v8: Remove dependency on xdisplaycheck BUG=670470 R=dpranke@chromium.org ========== to ========== v8: Remove dependency on xdisplaycheck BUG=670470 R=dpranke@chromium.org Committed: https://crrev.com/ed48cdbc6a36faf91f7f6c72ee3536a9d1eb1c68 Cr-Commit-Position: refs/heads/master@{#41460} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ed48cdbc6a36faf91f7f6c72ee3536a9d1eb1c68 Cr-Commit-Position: refs/heads/master@{#41460} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
