Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2544033003: Revert of Preparation CL for WebRTC performance test using promise-based getStats (Closed)

Created:
4 years ago by hbos_chromium
Modified:
4 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, phoglund+watch_chromium.org, mcasas+watch+vc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Preparation CL for WebRTC performance test using promise-based getStats (patchset #4 id:160001 of https://codereview.chromium.org/2534633002/ ) Reason for revert: Compile error on http://build.chromium.org/p/chromium.webrtc/builders/Linux%20Builder/builds/88436 due to uninitialized variables (warning treated as an error). False alarm warning but I'll have to init and reland Original issue's description: > Preparation CL for WebRTC performance test using promise-based getStats > > In order to have a perf test looking at stats of interest we need to be > able to get the results of a JavaScript getStats call. These can be > returned as JSON-stringified JavaScript dictionaries. > > In this CL: > - [g|G]etStatsReportDictionary added to webrtc_browsertest_base.cc and > peerconnection_getstats.js, which produce/read a JSON-stringified > version of the stats. > - RTCStatsReportDictionary and RTCStatsDictionary, helper classes for > reading stats from the base::Dictionary representation of the stats. > - Unittests for the helper classes. > > In a follow-up CL these methods/classes will be used to obtain the > stats in the to-be-added performance test. This will yield pretty > graphs. > > BUG=670306, 627816 > > Committed: https://crrev.com/c6ab14b0aa877c3e8e885934608d95849ff9a1a8 > Cr-Commit-Position: refs/heads/master@{#435894} TBR=phoglund@chromium.org,hta@chromium.org,tommi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=670306, 627816 Committed: https://crrev.com/f50152dfc457a09afb6dca4a6ea9942af9a3b07a Cr-Commit-Position: refs/heads/master@{#435897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -514 lines) Patch
D chrome/browser/media/webrtc/test_stats_dictionary.h View 1 chunk +0 lines, -85 lines 0 comments Download
D chrome/browser/media/webrtc/test_stats_dictionary.cc View 1 chunk +0 lines, -215 lines 0 comments Download
D chrome/browser/media/webrtc/test_stats_dictionary_unittest.cc View 1 chunk +0 lines, -167 lines 0 comments Download
M chrome/browser/media/webrtc/webrtc_browsertest_base.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/media/webrtc/webrtc_browsertest_base.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/webrtc/peerconnection_getstats.js View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
hbos_chromium
Created Revert of Preparation CL for WebRTC performance test using promise-based getStats
4 years ago (2016-12-02 09:38:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544033003/1
4 years ago (2016-12-02 09:38:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 09:39:42 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-02 09:41:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f50152dfc457a09afb6dca4a6ea9942af9a3b07a
Cr-Commit-Position: refs/heads/master@{#435897}

Powered by Google App Engine
This is Rietveld 408576698