DescriptionRevert of Preparation CL for WebRTC performance test using promise-based getStats (patchset #4 id:160001 of https://codereview.chromium.org/2534633002/ )
Reason for revert:
Compile error on http://build.chromium.org/p/chromium.webrtc/builders/Linux%20Builder/builds/88436 due to uninitialized variables (warning treated as an error).
False alarm warning but I'll have to init and reland
Original issue's description:
> Preparation CL for WebRTC performance test using promise-based getStats
>
> In order to have a perf test looking at stats of interest we need to be
> able to get the results of a JavaScript getStats call. These can be
> returned as JSON-stringified JavaScript dictionaries.
>
> In this CL:
> - [g|G]etStatsReportDictionary added to webrtc_browsertest_base.cc and
> peerconnection_getstats.js, which produce/read a JSON-stringified
> version of the stats.
> - RTCStatsReportDictionary and RTCStatsDictionary, helper classes for
> reading stats from the base::Dictionary representation of the stats.
> - Unittests for the helper classes.
>
> In a follow-up CL these methods/classes will be used to obtain the
> stats in the to-be-added performance test. This will yield pretty
> graphs.
>
> BUG=670306, 627816
>
> Committed: https://crrev.com/c6ab14b0aa877c3e8e885934608d95849ff9a1a8
> Cr-Commit-Position: refs/heads/master@{#435894}
TBR=phoglund@chromium.org,hta@chromium.org,tommi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=670306, 627816
Committed: https://crrev.com/f50152dfc457a09afb6dca4a6ea9942af9a3b07a
Cr-Commit-Position: refs/heads/master@{#435897}
Patch Set 1 #
Messages
Total messages: 8 (4 generated)
|